From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: pabeni@redhat.com, netdev@vger.kernel.org, edumazet@google.com,
kuznet@ms2.inr.ac.ru
Subject: Re: [RFC PATCH] IP: do not modify ingress packet IP option in ip_options_echo()
Date: Sun, 06 Aug 2017 20:49:49 -0700 (PDT) [thread overview]
Message-ID: <20170806.204949.1692038476128309810.davem@davemloft.net> (raw)
In-Reply-To: <87a83othjl.fsf@stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Fri, 28 Jul 2017 16:47:42 -0400
> David Miller <davem@davemloft.net> writes:
>
>> The red flag is that we are indexing 'start' with 'doffset' instead of
>> 'soffset'.
>
> As Paolo pointed out, we should not put our own source address into the
> options array.
>
> Do you have any idea why this code was added in the first place? I read
> through 2.0.33 code and even in context of this version, I couldn't
> figure that out.
>
> Because it seems the code and update is dead anyways (besides
> incorrectly updating the ICMP reflected payload) I don't see any problem
> with removing this code. Do you?
Ok, now I'm convinced it's dead code.
Thanks for explaining.
prev parent reply other threads:[~2017-08-07 3:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 13:55 [RFC PATCH] IP: do not modify ingress packet IP option in ip_options_echo() Paolo Abeni
2017-07-24 21:12 ` David Miller
2017-07-25 15:26 ` Paolo Abeni
2017-07-28 20:47 ` Hannes Frederic Sowa
2017-08-07 3:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170806.204949.1692038476128309810.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).