From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, daniel@iogearbox.net,
mlxsw@mellanox.com, andrew@lunn.ch,
vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com,
dirk.vandermerwe@netronome.com, alexander.h.duyck@intel.com,
amritha.nambiar@intel.com, oss-drivers@netronome.com
Subject: Re: [patch net-next 00/15] net: sched: summer cleanup part 2, ndo_setup_tc
Date: Sun, 06 Aug 2017 21:37:49 -0700 (PDT) [thread overview]
Message-ID: <20170806.213749.505593800109957053.davem@davemloft.net> (raw)
In-Reply-To: <20170805145337.17728-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Sat, 5 Aug 2017 16:53:22 +0200
> From: Jiri Pirko <jiri@mellanox.com>
>
> This patchset focuses on ndo_setup_tc and its args.
> Currently there are couple of things that do not make much sense.
> The type is passed in struct tc_to_netdev, but as it is always
> required, should be arg of the ndo. Other things are passed as args
> but they are only relevant for cls offloads and not mqprio. Therefore,
> they should be pushed to struct. As the tc_to_netdev struct in the end
> is just a container of single pointer, we get rid of it and pass the
> struct according to type. So in the end, we have:
> ndo_setup_tc(dev, type, type_data_struct)
>
> There are couple of cosmetics done on the way to make things smooth.
> Also, reported error is consolidated to eopnotsupp in case the
> asked offload is not supported.
Series applied, thanks Jiri.
next prev parent reply other threads:[~2017-08-07 4:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-05 14:53 [patch net-next 00/15] net: sched: summer cleanup part 2, ndo_setup_tc Jiri Pirko
2017-08-05 14:53 ` [patch net-next 01/15] net: sched: make type an argument for ndo_setup_tc Jiri Pirko
2017-08-05 14:53 ` [patch net-next 02/15] net: sched: rename TC_SETUP_MATCHALL to TC_SETUP_CLSMATCHALL Jiri Pirko
2017-08-05 14:53 ` [patch net-next 03/15] net: sched: make egress_dev flag part of flower offload struct Jiri Pirko
2017-08-05 14:53 ` [patch net-next 04/15] cxgb4: push cls_u32 setup_tc processing into a separate function Jiri Pirko
2017-08-05 14:53 ` [patch net-next 05/15] ixgbe: push cls_u32 and mqprio setup_tc processing into separate functions Jiri Pirko
2017-08-05 14:53 ` [patch net-next 06/15] mlx5e: push cls_flower " Jiri Pirko
2017-08-06 20:08 ` Saeed Mahameed
2017-08-05 14:53 ` [patch net-next 07/15] mlx5e_rep: push cls_flower setup_tc processing into a separate function Jiri Pirko
2017-08-05 14:53 ` [patch net-next 08/15] mlxsw: spectrum: push cls_flower and cls_matchall setup_tc processing into separate functions Jiri Pirko
2017-08-05 14:53 ` [patch net-next 09/15] mlxsw: spectrum: rename cls arg in matchall processing Jiri Pirko
2017-08-05 14:53 ` [patch net-next 10/15] dsa: push cls_matchall setup_tc processing into a separate function Jiri Pirko
2017-08-06 17:55 ` Florian Fainelli
2017-08-05 14:53 ` [patch net-next 11/15] nfp: change flows in apps that offload ndo_setup_tc Jiri Pirko
2017-08-05 14:53 ` [patch net-next 12/15] net: sched: push cls related args into cls_common structure Jiri Pirko
2017-08-05 14:53 ` [patch net-next 13/15] net: sched: move prio into cls_common Jiri Pirko
2017-08-05 14:53 ` [patch net-next 14/15] net: sched: change return value of ndo_setup_tc for driver supporting mqprio only Jiri Pirko
2017-08-05 14:53 ` [patch net-next 15/15] net: sched: get rid of struct tc_to_netdev Jiri Pirko
2017-08-06 12:28 ` [patch net-next 00/15] net: sched: summer cleanup part 2, ndo_setup_tc Jamal Hadi Salim
2017-08-07 4:37 ` David Miller [this message]
2017-08-07 5:27 ` Jiri Pirko
2017-08-07 6:09 ` David Miller
2017-08-07 6:21 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170806.213749.505593800109957053.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=amritha.nambiar@intel.com \
--cc=andrew@lunn.ch \
--cc=daniel@iogearbox.net \
--cc=dirk.vandermerwe@netronome.com \
--cc=f.fainelli@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=pieter.jansenvanvuuren@netronome.com \
--cc=simon.horman@netronome.com \
--cc=vivien.didelot@savoirfairelinux.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).