netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dsahern@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 0/7] net: l3mdev: Support for sockets bound to enslaved device
Date: Sun, 06 Aug 2017 23:51:45 -0700 (PDT)	[thread overview]
Message-ID: <20170806.235145.398118943167397128.davem@davemloft.net> (raw)
In-Reply-To: <20170806.213938.1049251959507174455.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Sun, 06 Aug 2017 21:39:38 -0700 (PDT)

> From: David Ahern <dsahern@gmail.com>
> Date: Fri,  4 Aug 2017 13:16:56 -0700
> 
>> A missing piece to the VRF puzzle is the ability to bind sockets to
>> devices enslaved to a VRF. This patch set adds the enslaved device
>> index, sdif, to IPv4 and IPv6 socket lookups. The end result for users
>> is the following scope options for services:
>> 
>> 1. "global" services - sockets not bound to any device
>> 
>>    Allows 1 service to work across all network interfaces with
>>    connected sockets bound to the VRF the connection originates
>>    (Requires net.ipv4.tcp_l3mdev_accept=1 for TCP and
>>     net.ipv4.udp_l3mdev_accept=1 for UDP)
>> 
>> 2. "VRF" local services - sockets bound to a VRF
>> 
>>    Sockets work across all network interfaces enslaved to a VRF but
>>    are limited to just the one VRF.
>> 
>> 3. "device" services - sockets bound to a specific network interface
>> 
>>    Service works only through the one specific interface.
>> 
>> v2
>> - remove sk_lookup struct and add sdif as an argument to existing
>>   functions
>> 
>> Changes since RFC:
>> - no significant logic changes; mainly whitespace cleanups
> 
> Series applied, thanks David.

David, I had to revert.  You didn't convert dccp which breaks
the build.

net/dccp/ipv4.c: In function ‘dccp_v4_err’:
net/dccp/ipv4.c:256:7: error: too few arguments to function ‘__inet_lookup_established’
  sk = __inet_lookup_established(net, &dccp_hashinfo,
       ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from net/dccp/ipv4.c:22:0:
./include/net/inet_hashtables.h:289:14: note: declared here
 struct sock *__inet_lookup_established(struct net *net,
              ^~~~~~~~~~~~~~~~~~~~~~~~~

Thanks.

  reply	other threads:[~2017-08-07  6:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-04 20:16 [PATCH v2 net-next 0/7] net: l3mdev: Support for sockets bound to enslaved device David Ahern
2017-08-04 20:16 ` [PATCH v2 net-next 1/7] net: ipv4: add second dif to udp socket lookups David Ahern
2017-08-04 20:16 ` [PATCH v2 net-next 2/7] net: ipv4: add second dif to inet " David Ahern
2017-08-04 20:16 ` [PATCH v2 net-next 3/7] net: ipv4: add second dif to raw " David Ahern
2017-08-04 20:17 ` [PATCH v2 net-next 4/7] net: ipv4: add second dif to multicast source filter David Ahern
2017-08-04 20:17 ` [PATCH v2 net-next 5/7] net: ipv6: add second dif to udp socket lookups David Ahern
2017-08-04 20:17 ` [PATCH v2 net-next 6/7] net: ipv6: add second dif to inet6 " David Ahern
2017-08-04 20:17 ` [PATCH v2 net-next 7/7] net: ipv6: add second dif to raw " David Ahern
2017-08-07  4:39 ` [PATCH v2 net-next 0/7] net: l3mdev: Support for sockets bound to enslaved device David Miller
2017-08-07  6:51   ` David Miller [this message]
2017-08-07 14:35     ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170806.235145.398118943167397128.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).