From: Willy Tarreau <w@1wt.eu>
To: maowenan <maowenan@huawei.com>
Cc: Neal Cardwell <ncardwell@google.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Yuchung Cheng <ycheng@google.com>,
Nandita Dukkipati <nanditad@google.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed
Date: Sun, 6 Aug 2017 09:44:35 +0200 [thread overview]
Message-ID: <20170806074435.GA13300@1wt.eu> (raw)
In-Reply-To: <F95AC9340317A84688A5F0DF0246F3F202940EA5@DGGEMI512-MBX.china.huawei.com>
On Sun, Aug 06, 2017 at 07:39:57AM +0000, maowenan wrote:
>
>
> > -----Original Message-----
> > From: Willy Tarreau [mailto:w@1wt.eu]
> > Sent: Saturday, August 05, 2017 2:19 AM
> > To: Neal Cardwell
> > Cc: maowenan; David Miller; netdev@vger.kernel.org; Yuchung Cheng; Nandita
> > Dukkipati; Eric Dumazet
> > Subject: Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data
> > ACKed/SACKed
> >
> > On Fri, Aug 04, 2017 at 02:01:34PM -0400, Neal Cardwell wrote:
> > > On Fri, Aug 4, 2017 at 1:10 PM, Willy Tarreau <w@1wt.eu> wrote:
> > > > Hi Neal,
> > > >
> > > > On Fri, Aug 04, 2017 at 12:59:51PM -0400, Neal Cardwell wrote:
> > > >> I have attached patches for this fix rebased on to v3.10.107, the
> > > >> latest stable release for 3.10. That's pretty far back in history,
> > > >> so there were substantial conflict resolutions and adjustments required.
> > > >> :-) Hope that helps.
> > > >
> > > > At least it will help me :-)
> > > >
> > > > Do you suggest that I queue them for 3.10.108, that I wait for
> > > > Maowenan to test them more broadly first or anything else ?
> > >
> > > Let's wait for Maowenan to test them first.
> [Mao Wenan]It works well with these patches of v3.10, and the
> retransmission packet is about 250ms after TLP probe.
> Thank you very much for these patches under 3.10.
Thanks, I'll take them then.
Willy
next prev parent reply other threads:[~2017-08-06 7:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 2:58 [PATCH net 0/3] tcp: fix xmit timer rearming to avoid stalls Neal Cardwell
2017-08-01 2:58 ` [PATCH net 1/3] tcp: introduce tcp_rto_delta_us() helper for xmit timer fix Neal Cardwell
2017-08-01 7:16 ` Eric Dumazet
2017-08-01 2:58 ` [PATCH net 2/3] tcp: enable xmit timer fix by having TLP use time when RTO should fire Neal Cardwell
2017-08-01 7:22 ` Eric Dumazet
2017-08-01 14:35 ` Neal Cardwell
2017-08-01 20:40 ` Eric Dumazet
2017-08-01 2:58 ` [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed Neal Cardwell
2017-08-01 7:25 ` Eric Dumazet
2017-08-01 12:20 ` maowenan
2017-08-01 14:24 ` Neal Cardwell
2017-08-04 7:12 ` maowenan
2017-08-04 15:54 ` Neal Cardwell
2017-08-04 7:33 ` maowenan
2017-08-04 16:59 ` Neal Cardwell
2017-08-04 17:10 ` Willy Tarreau
2017-08-04 18:01 ` Neal Cardwell
2017-08-04 18:18 ` Willy Tarreau
2017-08-06 7:39 ` maowenan
2017-08-06 7:44 ` Willy Tarreau [this message]
2017-08-06 15:21 ` Neal Cardwell
2017-08-06 15:24 ` Neal Cardwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170806074435.GA13300@1wt.eu \
--to=w@1wt.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=maowenan@huawei.com \
--cc=nanditad@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).