* [PATCH net-next] ibmvnic: Report rx buffer return codes as netdev_dbg
@ 2017-08-07 20:42 John Allen
2017-08-07 21:01 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: John Allen @ 2017-08-07 20:42 UTC (permalink / raw)
To: netdev; +Cc: Nathan Fontenot, Thomas Falcon
Reporting any return code for a receive buffer as an "rx error" only
produces alarming noise and the only values that have been observed to be
used in this field are not error conditions. Change this to a netdev_dbg
with a more descriptive message.
Signed-off-by: John Allen <jallen@linux.vnet.ibm.com>
---
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 5932160..99576ba 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -1579,7 +1579,8 @@ static int ibmvnic_poll(struct napi_struct *napi, int budget)
rx_comp.correlator);
/* do error checking */
if (next->rx_comp.rc) {
- netdev_err(netdev, "rx error %x\n", next->rx_comp.rc);
+ netdev_dbg(netdev, "rx buffer returned with rc %x\n",
+ be16_to_cpu(next->rx_comp.rc));
/* free the entry */
next->rx_comp.first = 0;
remove_buff_from_pool(adapter, rx_buff);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ibmvnic: Report rx buffer return codes as netdev_dbg
2017-08-07 20:42 [PATCH net-next] ibmvnic: Report rx buffer return codes as netdev_dbg John Allen
@ 2017-08-07 21:01 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-08-07 21:01 UTC (permalink / raw)
To: jallen; +Cc: netdev, nfont, tlfalcon
From: John Allen <jallen@linux.vnet.ibm.com>
Date: Mon, 7 Aug 2017 15:42:30 -0500
> Reporting any return code for a receive buffer as an "rx error" only
> produces alarming noise and the only values that have been observed to be
> used in this field are not error conditions. Change this to a netdev_dbg
> with a more descriptive message.
>
> Signed-off-by: John Allen <jallen@linux.vnet.ibm.com>
Applied, thanks John.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-07 21:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-07 20:42 [PATCH net-next] ibmvnic: Report rx buffer return codes as netdev_dbg John Allen
2017-08-07 21:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).