From: Stephen Hemminger <stephen@networkplumber.org>
To: Christian Langrock <christian.langrock@secunet.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH] ip/link_vti*.c: Fix output for ikey/okey
Date: Mon, 7 Aug 2017 15:38:15 -0700 [thread overview]
Message-ID: <20170807153815.7acf5b93@xeon-e3> (raw)
In-Reply-To: <bf2d09ad-28b8-c64c-dd60-4fb288259e3e@secunet.com>
[-- Attachment #1: Type: text/plain, Size: 565 bytes --]
On Mon, 7 Aug 2017 11:59:28 +0200
Christian Langrock <christian.langrock@secunet.com> wrote:
> ikey and okey are normal u32 values. There's no reason to print them as
> IPv4/IPv6 addresses.
>
> Signed-off-by: Christian Langrock <christian.langrock@secunet.com>
Changing output format breaks scripts that parse output.
But on the other hand, the VTI code breaks the assumption that ip command
output should be the same as input.
More likely the original output format was done to match Cisco output.
Why not print in hex like fwmark?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-07 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 9:59 [PATCH] ip/link_vti*.c: Fix output for ikey/okey Christian Langrock
2017-08-07 22:38 ` Stephen Hemminger [this message]
2017-08-08 6:24 ` Christian Langrock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807153815.7acf5b93@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=christian.langrock@secunet.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).