From: David Miller <davem@davemloft.net>
To: james.hogan@imgtec.com
Cc: daniel@iogearbox.net, ast@kernel.org,
linux-kernel@vger.kernel.org, rostedt@goodmis.org,
mingo@redhat.com, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] bpf: Initialise mod[] in bpf_trace_printk
Date: Tue, 08 Aug 2017 14:54:33 -0700 (PDT) [thread overview]
Message-ID: <20170808.145433.1287676484744976417.davem@davemloft.net> (raw)
In-Reply-To: <650EB3B0-1101-4624-905A-E68D2EC5920F@imgtec.com>
From: James Hogan <james.hogan@imgtec.com>
Date: Tue, 08 Aug 2017 22:20:05 +0100
> cool, i hadn't realised unmentioned elements in an initialiser are
> always zeroed, even when non-global/static, so had interpreted the
> whole array as uninitialised. learn something new every day :-)
> sorry for the noise.
You didn't have to know in the first place, you could have simply
compiled the code into assembler by running:
make kernel/trace/bpf_trace.s
and seen for yourself before putting all of this time and effort into
this patch and discussion.
If you don't know what the compiler does, simply look!
next prev parent reply other threads:[~2017-08-08 21:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 22:25 [RFC PATCH 0/2] bpf_trace_printk() fixes James Hogan
2017-08-07 22:25 ` [RFC PATCH 1/2] bpf: Fix bpf_trace_printk on 32-bit architectures James Hogan
2017-08-07 22:25 ` [RFC PATCH 2/2] bpf: Initialise mod[] in bpf_trace_printk James Hogan
2017-08-08 8:46 ` Daniel Borkmann
2017-08-08 16:48 ` David Miller
2017-08-08 21:20 ` James Hogan
2017-08-08 21:54 ` David Miller [this message]
2017-08-09 7:39 ` James Hogan
2017-08-09 20:34 ` Daniel Borkmann
2017-08-11 16:47 ` Daniel Borkmann
2017-08-14 12:25 ` James Hogan
2017-08-14 12:44 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808.145433.1287676484744976417.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).