From: David Miller <davem@davemloft.net>
To: mic@digikod.net
Cc: linux-kernel@vger.kernel.org, ast@fb.com, daniel@iogearbox.net,
keescook@chromium.org, kafai@fb.com, netdev@vger.kernel.org,
ast@kernel.org
Subject: Re: [PATCH net-next v2 2/2] bpf: Extend check_uarg_tail_zero() checks
Date: Tue, 08 Aug 2017 18:11:33 -0700 (PDT) [thread overview]
Message-ID: <20170808.181133.1654188772199067010.davem@davemloft.net> (raw)
In-Reply-To: <20170807184520.8130-2-mic@digikod.net>
From: Mickaël Salaün <mic@digikod.net>
Date: Mon, 7 Aug 2017 20:45:20 +0200
> The function check_uarg_tail_zero() was created from bpf(2) for
> BPF_OBJ_GET_INFO_BY_FD without taking the access_ok() nor the PAGE_SIZE
> checks. Make this checks more generally available while unlikely to be
> triggered, extend the memory range check and add an explanation
> including why the ToCToU should not be a security concern.
>
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Martin KaFai Lau <kafai@fb.com>
> Link: https://lkml.kernel.org/r/CAGXu5j+vRGFvJZmjtAcT8Hi8B+Wz0e1b6VKYZHfQP_=DXzC4CQ@mail.gmail.com
Applied.
next prev parent reply other threads:[~2017-08-09 1:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 18:45 [PATCH net-next v2 1/2] bpf: Move check_uarg_tail_zero() upward Mickaël Salaün
2017-08-07 18:45 ` [PATCH net-next v2 2/2] bpf: Extend check_uarg_tail_zero() checks Mickaël Salaün
2017-08-09 1:11 ` David Miller [this message]
2017-08-09 1:11 ` [PATCH net-next v2 1/2] bpf: Move check_uarg_tail_zero() upward David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808.181133.1654188772199067010.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@fb.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mic@digikod.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).