From: David Miller <davem@davemloft.net>
To: otubo@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, sthemmin@microsoft.com,
haiyangz@microsoft.com, kys@microsoft.com
Subject: Re: [PATCH] hv_set_ifconfig.sh double check before setting ip
Date: Tue, 08 Aug 2017 21:11:50 -0700 (PDT) [thread overview]
Message-ID: <20170808.211150.2070475124549651350.davem@davemloft.net> (raw)
In-Reply-To: <20170808135345.17027-1-otubo@redhat.com>
From: Eduardo Otubo <otubo@redhat.com>
Date: Tue, 8 Aug 2017 15:53:45 +0200
> This patch fixes the behavior of the hv_set_ifconfig script when setting
> the interface ip. Sometimes the interface has already been configured by
> network daemon, in this case hv_set_ifconfig causes "RTNETLINK: file
> exists error"; in order to avoid this error this patch makes sure double
> checks the interface before trying anything.
>
> Signed-off-by: Eduardo Otubo <otubo@redhat.com>
And if the daemon sets the address after you test it but before
you try to set it in the script, what happens?
This is why I hate changes like this. They don't remove the problem,
they make it smaller. And smaller in a bad way. Smaller makes the
problem even more harder to diagnose when it happens.
There is implicitly no synchonization between network configuration
daemons and things people run by hand like this script.
So, caveat emptor.
I'm not applying this, sorry.
next prev parent reply other threads:[~2017-08-09 4:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 13:53 [PATCH] hv_set_ifconfig.sh double check before setting ip Eduardo Otubo
2017-08-09 4:11 ` David Miller [this message]
2017-08-09 9:02 ` Eduardo Otubo
2017-08-10 7:40 ` Eduardo Otubo
2017-08-10 16:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808.211150.2070475124549651350.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=otubo@redhat.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).