From: Stephen Hemminger <stephen@networkplumber.org>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, devel@linuxdriverproject.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/1] netvsc: another VF datapath fix
Date: Tue, 8 Aug 2017 08:15:06 -0700 [thread overview]
Message-ID: <20170808081506.38bea86c@xeon-e3> (raw)
In-Reply-To: <87ziba9mwj.fsf@vitty.brq.redhat.com>
On Tue, 08 Aug 2017 16:03:56 +0200
Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
> Stephen Hemminger <stephen@networkplumber.org> writes:
>
> > Previous fix was incomplete.
> >
>
> Not really related to this patch series (which btw fixes my issue,
> thanks!), but I found one addition issue. Systemd fails to rename VF
> interface:
>
> kernel: mlx4_core 0002:00:02.0 eth2: joined to eth1
> kernel: hv_netvsc 33b7a6f9-6736-451f-8fce-b382eaa50bee eth1: VF registering: eth2
> kernel: hv_netvsc 33b7a6f9-6736-451f-8fce-b382eaa50bee eth1: Data path switched to VF: eth2
> kernel: mlx4_en: eth2: Link Up
> NetworkManager[750]: <info> [1502200557.0821] device (eth2): link connected
> NetworkManager[750]: <info> [1502200557.1004] manager: (eth2): new Ethernet device (/org/freedesktop/NetworkManager/Devices/6)
> systemd-udevd[6942]: Error changing net interface name 'eth2' to 'enP2p0s2': Device or resource busy
> systemd-udevd[6942]: could not rename interface '6' from 'eth2' to 'enP2p0s2': Device or resource busy
>
> With some debug added I figured out what's wrong: __netvsc_vf_setup()
> does dev_open() which sets IFF_UP flag on the interface. When systemd
> tries to rename the interface we get into dev_change_name() and this
> fails with -EBUSY when (dev->flags & IFF_UP).
>
> The issue is of less importance as we're not supposed to configure VF
> interface now. However, we may still want to get a stable name for it.
>
> Any idea how this can be fixed?
The problem is Network Manager should ignore the VF device. I don't run NM on these
interfaces because it causes more issues than it helps (dueling userspace).
The driver needs to have slave track the master interface. Relying on userspace
to bring interface up leads to all the issues the bonding script had.
One option would be to delay the work of bringing up the slave device to allow
small window for renaming to run.
next prev parent reply other threads:[~2017-08-08 15:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 18:29 [PATCH net-next 0/1] netvsc: another VF datapath fix Stephen Hemminger
2017-08-07 18:30 ` [PATCH net-next 1/1] netvsc: make sure and unregister datapath Stephen Hemminger
2017-08-09 1:10 ` David Miller
2017-08-08 14:03 ` [PATCH net-next 0/1] netvsc: another VF datapath fix Vitaly Kuznetsov
2017-08-08 15:15 ` Stephen Hemminger [this message]
2017-08-08 15:24 ` Vitaly Kuznetsov
2017-08-08 15:29 ` Stephen Hemminger
2017-08-08 15:42 ` Vitaly Kuznetsov
2017-08-08 15:53 ` Stephen Hemminger
2017-08-09 9:03 ` Vitaly Kuznetsov
2017-08-09 14:41 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808081506.38bea86c@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox