From: David Miller <davem@davemloft.net>
To: willemdebruijn.kernel@gmail.com
Cc: netdev@vger.kernel.org, andreyknvl@gmail.com, willemb@google.com
Subject: Re: [PATCH net] udp: consistently apply ufo or fragmentation
Date: Thu, 10 Aug 2017 09:52:26 -0700 (PDT) [thread overview]
Message-ID: <20170810.095226.1892134367440824522.davem@davemloft.net> (raw)
In-Reply-To: <20170810162919.50577-1-willemdebruijn.kernel@gmail.com>
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Thu, 10 Aug 2017 12:29:19 -0400
> From: Willem de Bruijn <willemb@google.com>
>
> When iteratively building a UDP datagram with MSG_MORE and that
> datagram exceeds MTU, consistently choose UFO or fragmentation.
>
> Once skb_is_gso, always apply ufo. Conversely, once a datagram is
> split across multiple skbs, do not consider ufo.
>
> Sendpage already maintains the first invariant, only add the second.
> IPv6 does not have a sendpage implementation to modify.
>
> A gso skb must have a partial checksum, do not follow sk_no_check_tx
> in udp_send_skb.
>
> Found by syzkaller.
>
> Fixes: e89e9cf539a2 ("[IPv4/IPv6]: UFO Scatter-gather approach")
> Reported-by: Andrey Konovalov <andreyknvl@google.com>
> Signed-off-by: Willem de Bruijn <willemb@google.com>
Applied and queued up for -stable.
next prev parent reply other threads:[~2017-08-10 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 16:29 [PATCH net] udp: consistently apply ufo or fragmentation Willem de Bruijn
2017-08-10 16:52 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-14 11:31 Vasily Averin
2017-08-14 14:53 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810.095226.1892134367440824522.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andreyknvl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox