* [PATCH net-next] phylink: Fix an uninitialized variable bug
@ 2017-08-09 21:35 Dan Carpenter
2017-08-10 15:21 ` Andrew Lunn
2017-08-11 20:58 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-08-09 21:35 UTC (permalink / raw)
To: Andrew Lunn, Russell King; +Cc: Florian Fainelli, netdev, kernel-janitors
"ret" isn't necessarily initialized here.
Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 32917bdd1432..bcb4755bcd95 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -958,7 +958,7 @@ int phylink_ethtool_ksettings_set(struct phylink *pl,
}
mutex_unlock(&pl->state_mutex);
- return ret;
+ return 0;
}
EXPORT_SYMBOL_GPL(phylink_ethtool_ksettings_set);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] phylink: Fix an uninitialized variable bug
2017-08-09 21:35 [PATCH net-next] phylink: Fix an uninitialized variable bug Dan Carpenter
@ 2017-08-10 15:21 ` Andrew Lunn
2017-08-17 9:02 ` Russell King - ARM Linux
2017-08-11 20:58 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Lunn @ 2017-08-10 15:21 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Russell King, Florian Fainelli, netdev, kernel-janitors
On Thu, Aug 10, 2017 at 12:35:50AM +0300, Dan Carpenter wrote:
> "ret" isn't necessarily initialized here.
>
> Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] phylink: Fix an uninitialized variable bug
2017-08-09 21:35 [PATCH net-next] phylink: Fix an uninitialized variable bug Dan Carpenter
2017-08-10 15:21 ` Andrew Lunn
@ 2017-08-11 20:58 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2017-08-11 20:58 UTC (permalink / raw)
To: dan.carpenter; +Cc: andrew, rmk+kernel, f.fainelli, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 10 Aug 2017 00:35:50 +0300
> "ret" isn't necessarily initialized here.
>
> Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] phylink: Fix an uninitialized variable bug
2017-08-10 15:21 ` Andrew Lunn
@ 2017-08-17 9:02 ` Russell King - ARM Linux
0 siblings, 0 replies; 4+ messages in thread
From: Russell King - ARM Linux @ 2017-08-17 9:02 UTC (permalink / raw)
To: Andrew Lunn; +Cc: Dan Carpenter, Florian Fainelli, netdev, kernel-janitors
On Thu, Aug 10, 2017 at 05:21:12PM +0200, Andrew Lunn wrote:
> On Thu, Aug 10, 2017 at 12:35:50AM +0300, Dan Carpenter wrote:
> > "ret" isn't necessarily initialized here.
> >
> > Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks, not sure how that got missed - it was probably introduced when
migrating the code to ksettings.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-17 9:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-09 21:35 [PATCH net-next] phylink: Fix an uninitialized variable bug Dan Carpenter
2017-08-10 15:21 ` Andrew Lunn
2017-08-17 9:02 ` Russell King - ARM Linux
2017-08-11 20:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).