From: David Miller <davem@davemloft.net>
To: girish.moodalbail@oracle.com
Cc: pshelar@ovn.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] geneve: use netlink_ext_ack for error reporting in rtnl operations
Date: Fri, 11 Aug 2017 13:45:14 -0700 (PDT) [thread overview]
Message-ID: <20170811.134514.1496944956776826656.davem@davemloft.net> (raw)
In-Reply-To: <1502266168-12107-1-git-send-email-girish.moodalbail@oracle.com>
From: Girish Moodalbail <girish.moodalbail@oracle.com>
Date: Wed, 9 Aug 2017 01:09:28 -0700
> Add extack error messages for failure paths while creating/modifying
> geneve devices. Once extack support is added to iproute2, more
> meaningful and helpful error messages will be displayed making it easy
> for users to discern what went wrong.
>
> Before:
> =======
> $ ip link add gen1 address 0:1:2:3:4:5:6 type geneve id 200 \
> remote 192.168.13.2
> RTNETLINK answers: Invalid argument
>
> After:
> ======
> $ ip link add gen1 address 0:1:2:3:4:5:6 type geneve id 200 \
> remote 192.168.13.2
> Error: Provided link layer address is not Ethernet
>
> Also, netdev_dbg() calls used to log errors associated with Netlink
> request have been removed.
>
> Signed-off-by: Girish Moodalbail <girish.moodalbail@oracle.com>
Applied, thanks.
prev parent reply other threads:[~2017-08-11 20:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 8:09 [PATCH net-next] geneve: use netlink_ext_ack for error reporting in rtnl operations Girish Moodalbail
2017-08-11 20:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811.134514.1496944956776826656.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=girish.moodalbail@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).