From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: fw@strlen.de, khlebnikov@yandex-team.ru, netdev@vger.kernel.org,
jiri@mellanox.com, jhs@mojatatu.com
Subject: Re: [PATCH] net/sched: reset block pointer in tcf_block_put()
Date: Fri, 11 Aug 2017 14:21:00 -0700 (PDT) [thread overview]
Message-ID: <20170811.142100.465766359895148878.davem@davemloft.net> (raw)
In-Reply-To: <CAM_iQpUoa5vWfQGpqCJ7dXx542uC-5JyNpRK-zukVbq=EfAAEA@mail.gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Fri, 11 Aug 2017 14:06:31 -0700
> On Fri, Aug 11, 2017 at 1:32 PM, Florian Westphal <fw@strlen.de> wrote:
>> Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>> On Thu, Aug 10, 2017 at 2:31 AM, Konstantin Khlebnikov
>>> <khlebnikov@yandex-team.ru> wrote:
>>> > In previous API tcf_destroy_chain() could be called several times and
>>> > some schedulers like hfsc and atm use that. In new API tcf_block_put()
>>> > frees block but leaves stale pointer, second call will free it once again.
>>>
>>> Which call path do we call tcf_block_put() for multiple times on
>>> the same block? Please be specific, it is not obvious.
>>
>> you can use tools/testing/selftests/net/rtnetlink.sh to reproduce this
>> (kernel panics on delete of root qdisc).
>
> I am sure this is not how changelog works. We have enough space
> in changelog to describe a bug, don't have to leave details in a
> following-up email which will almost surely be lost in history.
Yeah, the more information in the commit log message the better.
next prev parent reply other threads:[~2017-08-11 21:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 9:31 [PATCH] net/sched: reset block pointer in tcf_block_put() Konstantin Khlebnikov
2017-08-11 20:18 ` Cong Wang
2017-08-11 20:32 ` Florian Westphal
2017-08-11 21:06 ` Cong Wang
2017-08-11 21:21 ` David Miller [this message]
2017-08-11 20:36 ` Konstantin Khlebnikov
2017-08-11 21:38 ` Cong Wang
2017-08-14 12:59 ` Konstantin Khlebnikov
2017-08-14 21:15 ` Cong Wang
2017-08-15 13:48 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811.142100.465766359895148878.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=khlebnikov@yandex-team.ru \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).