From: David Miller <davem@davemloft.net>
To: simon.horman@netronome.com
Cc: jakub.kicinski@netronome.com, netdev@vger.kernel.org,
oss-drivers@netronome.com
Subject: Re: [PATCH net repost] nfp: do not update MTU from BH in flower app
Date: Fri, 11 Aug 2017 14:51:07 -0700 (PDT) [thread overview]
Message-ID: <20170811.145107.1539668262080149471.davem@davemloft.net> (raw)
In-Reply-To: <1502439500-16047-1-git-send-email-simon.horman@netronome.com>
From: Simon Horman <simon.horman@netronome.com>
Date: Fri, 11 Aug 2017 10:18:20 +0200
> The Flower app may receive a request to update the MTU of a representor
> netdev upon receipt of a control message from the firmware. This requires
> the RTNL lock which needs to be taken outside of the packet processing
> path.
>
> As a handling of this correctly seems a little to invasive for a fix simply
> skip setting the MTU for now.
>
> Relevant backtrace:
...
> Fixes: 948faa46c05b ("nfp: add support for control messages for flower app")
> Signed-off-by: Simon Horman <simon.horman@netronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Applied.
next prev parent reply other threads:[~2017-08-11 21:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 8:18 [PATCH net repost] nfp: do not update MTU from BH in flower app Simon Horman
2017-08-11 21:51 ` David Miller [this message]
2017-08-15 6:13 ` Simon Horman
2017-08-16 0:52 ` David Miller
2017-08-16 4:03 ` David Miller
2017-08-16 5:35 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811.145107.1539668262080149471.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).