From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Benc Subject: Re: [PATCH net-next v2] openvswitch: enable NSH support Date: Fri, 11 Aug 2017 12:22:56 +0200 Message-ID: <20170811122256.2cec123e@griffin> References: <1502371275-52446-1-git-send-email-yi.y.yang@intel.com> <20170811102418.6b1be4f7@griffin> <20170811084722.GA19968@cran64.bj.intel.com> <20170811111055.482bd42b@griffin> <79BBBFE6CB6C9B488C1A45ACD284F51961C427FE@SHSMSX103.ccr.corp.intel.com> <20170811114449.745c49c5@griffin> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org" To: Jan Scheurich Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Errors-To: ovs-dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org List-Id: netdev.vger.kernel.org On Fri, 11 Aug 2017 10:09:36 +0000, Jan Scheurich wrote: > Unless someone can explain to me why the datapath should understand the > internal structure/format of metadata in push_nsh, I would strongly > vote to keep the metadata as variable length octet sequence in the > non-structured OVS_ACTION_ATTR_PUSH_NSH Could be but it still needs to be in a different attribute and not in the ovs_action_push_nsh structure. Separate attributes for MD1/MD2 has the advantage of easier validation: with a separate MD1 type attribute, the size check is easier. With an unstructured MD attribute, we'd need to look into the OVS_ACTION_ATTR_NSH_BASE_HEADER attribute for mdtype and then validate the unstructured MD attribute size manually. Not a big deal, though. I don't have strong opinion here. But I do have strong opinion that MD needs to go into a separate attribute, whether there are separate attributes for MD1/2 or not. Jiri