netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Lamparter <equinox@diac24.net>
To: Amine Kherbouche <amine.kherbouche@6wind.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
	David Lamparter <equinox@diac24.net>
Subject: Re: [PATCH 1/2] mpls: add handlers
Date: Fri, 11 Aug 2017 14:34:05 +0200	[thread overview]
Message-ID: <20170811123405.GY773745@eidolon> (raw)
In-Reply-To: <1502396917-14848-2-git-send-email-amine.kherbouche@6wind.com>

On Thu, Aug 10, 2017 at 10:28:36PM +0200, Amine Kherbouche wrote:
> Mpls handler allows creation/deletion of mpls routes without using
> rtnetlink. When an incoming mpls packet matches this route, the saved
> function handler is called.

Since I originally authored this patch, I have come to believe that it
might be unneccessarily complicated.  It is unlikely that a lot of
different "handlers" will exist here;  the only things I can think of
are VPLS support and BIER-MPLS multicast replication.  I'm not saying
it's a bad idea, but, well, this was in the README that I gave to 6WIND
with this code:

...
MPLS layer:
- the "MPT_HANDLER" thing is probably overkill, it likely makes more sense to
  tie in the VPLS code more directly.
...


-David

  reply	other threads:[~2017-08-11 12:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-10 20:28 [RFC PATCH 0/2] Support of VPLS MPLS Amine Kherbouche
2017-08-10 20:28 ` [PATCH 1/2] mpls: add handlers Amine Kherbouche
2017-08-11 12:34   ` David Lamparter [this message]
2017-08-11 14:37     ` Roopa Prabhu
2017-08-12 13:35       ` Amine Kherbouche
2017-08-13  3:29         ` Roopa Prabhu
2017-08-15  9:37           ` David Lamparter
2017-08-16  5:30             ` Roopa Prabhu
2017-08-16 10:24               ` Amine Kherbouche
2017-08-10 20:28 ` [PATCH 2/2] drivers: add vpls support Amine Kherbouche
2017-08-11 12:55   ` David Lamparter
2017-08-11 15:14     ` Roopa Prabhu
2017-08-12 13:40       ` Amine Kherbouche
2017-08-13  2:46         ` Roopa Prabhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170811123405.GY773745@eidolon \
    --to=equinox@diac24.net \
    --cc=amine.kherbouche@6wind.com \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).