From: Stephen Hemminger <stephen@networkplumber.org>
To: <Bryan.Whitehead@microchip.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next 1/3] Add LAN743X driver
Date: Fri, 11 Aug 2017 15:49:55 -0700 [thread overview]
Message-ID: <20170811154955.47c9cf74@xeon-e3> (raw)
In-Reply-To: <90A7E81AE28BAE4CBDDB3B35F187D264406F603F@CHN-SV-EXMX02.mchp-main.com>
;
> +
> +static void lan743x_rx_isr(void *context, u32 int_sts);
> +
> +static int lan743x_rx_ring_init(struct lan743x_rx *rx);
> +static void lan743x_rx_ring_cleanup(struct lan743x_rx *rx);
> +static int lan743x_rx_init(struct lan743x_rx *rx,
> + struct lan743x_adapter *adapter, int channel_number);
> +static void lan743x_rx_cleanup(struct lan743x_rx *rx);
> +static int lan743x_rx_open(struct lan743x_rx *rx);
> +static void lan743x_rx_close(struct lan743x_rx *rx);
> +
Please don't create a header file full of static declarations.
Header files are for shared data between compilation units.
Also, Linux style is to order functions to minimize the number
of required forward declarations.
next prev parent reply other threads:[~2017-08-11 22:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 19:47 [PATCH net-next 1/3] Add LAN743X driver Bryan.Whitehead
2017-08-11 22:12 ` David Miller
2017-08-11 22:34 ` Andrew Lunn
2017-08-14 16:13 ` Bryan.Whitehead
2017-08-14 16:12 ` Bryan.Whitehead
2017-08-11 22:31 ` Andrew Lunn
2017-08-11 22:49 ` Stephen Hemminger [this message]
2017-08-11 22:50 ` Stephen Hemminger
2017-08-11 22:52 ` Stephen Hemminger
2017-08-11 22:57 ` Stephen Hemminger
2017-08-11 22:59 ` Stephen Hemminger
2017-08-11 23:05 ` Stephen Hemminger
2017-08-14 16:15 ` Bryan.Whitehead
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811154955.47c9cf74@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=Bryan.Whitehead@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox