From: Jiri Benc <jbenc@redhat.com>
To: Girish Moodalbail <girish.moodalbail@oracle.com>
Cc: <pshelar@ovn.org>, <davem@davemloft.net>,
<netdev@vger.kernel.org>,
mschiffer@universe-factory.net, roopa@cumulusnetworks.com
Subject: Re: [PATCH net-next v2] vxlan: change vxlan_[config_]validate() to use netlink_ext_ack for error reporting
Date: Fri, 11 Aug 2017 17:47:31 +0200 [thread overview]
Message-ID: <20170811174731.51b71c65@griffin> (raw)
In-Reply-To: <1502399795-25660-1-git-send-email-girish.moodalbail@oracle.com>
On Thu, 10 Aug 2017 14:16:35 -0700, Girish Moodalbail wrote:
> + NL_SET_ERR_MSG_ATTR(extack, tb[IFLA_VXLAN_PORT_RANGE],
> + "Provided source port range bounds is invalid");
s/bounds//?
> + if (conf->label && !use_ipv6) {
> + NL_SET_ERR_MSG(extack,
> + "Label attribute only applies for IPv6 VXLAN devices");
applies to
> + if (!lowerdev) {
> + NL_SET_ERR_MSG(extack,
> + "Specified interface for tunnel endpoint communications not found");
s/communications//?
> + if (vxlan_addr_multicast(&conf->remote_ip)) {
> + NL_SET_ERR_MSG(extack,
> + "Interface need to be specified for multicast destination");
needs
> + if (conf->flags & VXLAN_F_IPV6_LINKLOCAL) {
> + NL_SET_ERR_MSG(extack,
> + "Interface need to be specified for link-local local/remote addresses");
needs
Looks good to me otherwise, thanks!
Jiri
next prev parent reply other threads:[~2017-08-11 15:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 21:16 [PATCH net-next v2] vxlan: change vxlan_[config_]validate() to use netlink_ext_ack for error reporting Girish Moodalbail
2017-08-11 15:47 ` Jiri Benc [this message]
2017-08-11 16:19 ` Roopa Prabhu
2017-08-11 16:24 ` Matthias Schiffer
2017-08-11 16:39 ` Jiri Benc
2017-08-11 16:56 ` David Ahern
2017-08-11 17:11 ` Jiri Benc
2017-08-11 17:17 ` David Ahern
2017-08-11 17:28 ` Jiri Benc
2017-08-11 17:21 ` Girish Moodalbail
2017-08-12 2:24 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811174731.51b71c65@griffin \
--to=jbenc@redhat.com \
--cc=davem@davemloft.net \
--cc=girish.moodalbail@oracle.com \
--cc=mschiffer@universe-factory.net \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).