From: Leon Romanovsky <leon@kernel.org>
To: Ohad Oz <ohado@mellanox.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jiri@resnulli.us,
saeedm@mellanox.com, vadimp@mellanox.com,
system-sw-low-level@mellanox.com
Subject: Re: [patch v1 1/2] Allow Mellanox network vendor to be configured if only I2C bus is configured
Date: Sat, 12 Aug 2017 17:37:15 +0300 [thread overview]
Message-ID: <20170812143715.GN24282@mtr-leonro.local> (raw)
In-Reply-To: <1502385112-103765-1-git-send-email-ohado@mellanox.com>
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
On Thu, Aug 10, 2017 at 05:11:51PM +0000, Ohad Oz wrote:
> Patch allows Mellanox devices on system with no PCI, but with I2C only.
>
Did you test mlx5 device on such system? Did it work for you?
What is the changelog between v0 and v1 of these patches?
> Signed-off-by: Ohad Oz <ohado@mellanox.com>
> ---
> drivers/net/ethernet/mellanox/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/Kconfig b/drivers/net/ethernet/mellanox/Kconfig
> index 84a2007..0949741 100644
> --- a/drivers/net/ethernet/mellanox/Kconfig
> +++ b/drivers/net/ethernet/mellanox/Kconfig
> @@ -5,7 +5,7 @@
> config NET_VENDOR_MELLANOX
> bool "Mellanox devices"
> default y
> - depends on PCI
> + depends on PCI || I2C
> ---help---
> If you have a network (Ethernet) card belonging to this class, say Y.
>
> --
> 2.8.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-12 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 17:11 [patch v1 1/2] Allow Mellanox network vendor to be configured if only I2C bus is configured Ohad Oz
2017-08-10 17:11 ` [patch v1 2/2] Change Kconfig description Ohad Oz
2017-08-12 14:37 ` Leon Romanovsky [this message]
2017-08-13 15:26 ` [patch v1 1/2] Allow Mellanox network vendor to be configured if only I2C bus is configured Ohad Oz
2017-08-14 0:25 ` David Miller
2017-08-14 5:20 ` Leon Romanovsky
2017-08-14 7:00 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170812143715.GN24282@mtr-leonro.local \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=ohado@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=system-sw-low-level@mellanox.com \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).