* [PATCH] rtlwifi: btcoex: make function btc8723b2ant_dac_swing static
@ 2017-08-12 22:00 Colin King
2017-08-12 22:02 ` NACK: " Colin Ian King
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-08-12 22:00 UTC (permalink / raw)
To: Larry Finger, Chaoming Li, Kalle Valo, Yan-Hsuan Chuang,
linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function btc8723b2ant_dac_swing is local to the source and
does not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'btc8723b2ant_dac_swing' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
index 31965f0ef69d..9d2ecfbc7b33 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
@@ -833,9 +833,9 @@ static void btc8723b2ant_set_sw_fulltime_dac_swing(struct btc_coexist *btcoex,
btc8723b2ant_set_dac_swing_reg(btcoex, 0x18);
}
-void btc8723b2ant_dac_swing(struct btc_coexist *btcoexist,
- bool force_exec, bool dac_swing_on,
- u32 dac_swing_lvl)
+static void btc8723b2ant_dac_swing(struct btc_coexist *btcoexist,
+ bool force_exec, bool dac_swing_on,
+ u32 dac_swing_lvl)
{
struct rtl_priv *rtlpriv = btcoexist->adapter;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* NACK: [PATCH] rtlwifi: btcoex: make function btc8723b2ant_dac_swing static
2017-08-12 22:00 [PATCH] rtlwifi: btcoex: make function btc8723b2ant_dac_swing static Colin King
@ 2017-08-12 22:02 ` Colin Ian King
0 siblings, 0 replies; 2+ messages in thread
From: Colin Ian King @ 2017-08-12 22:02 UTC (permalink / raw)
To: Larry Finger, Chaoming Li, Kalle Valo, Yan-Hsuan Chuang,
linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
On 12/08/17 23:00, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function btc8723b2ant_dac_swing is local to the source and
> does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'btc8723b2ant_dac_swing' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
> index 31965f0ef69d..9d2ecfbc7b33 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
> @@ -833,9 +833,9 @@ static void btc8723b2ant_set_sw_fulltime_dac_swing(struct btc_coexist *btcoex,
> btc8723b2ant_set_dac_swing_reg(btcoex, 0x18);
> }
>
> -void btc8723b2ant_dac_swing(struct btc_coexist *btcoexist,
> - bool force_exec, bool dac_swing_on,
> - u32 dac_swing_lvl)
> +static void btc8723b2ant_dac_swing(struct btc_coexist *btcoexist,
> + bool force_exec, bool dac_swing_on,
> + u32 dac_swing_lvl)
> {
> struct rtl_priv *rtlpriv = btcoexist->adapter;
>
>
Sent out wrong patch. Please ignore.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-12 22:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-12 22:00 [PATCH] rtlwifi: btcoex: make function btc8723b2ant_dac_swing static Colin King
2017-08-12 22:02 ` NACK: " Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).