From: David Miller <davem@davemloft.net>
To: felix.manlunas@cavium.com
Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com,
derek.chickles@cavium.com, satananda.burla@cavium.com,
intiyaz.basha@cavium.com
Subject: Re: [PATCH net-next 8/8] liquidio: added support for ethtool --set-ring feature
Date: Sun, 13 Aug 2017 19:43:15 -0700 (PDT) [thread overview]
Message-ID: <20170813.194315.2299024672935275105.davem@davemloft.net> (raw)
In-Reply-To: <20170812012930.GA2614@felix-thinkpad.cavium.com>
From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Fri, 11 Aug 2017 18:29:30 -0700
> + if ((ering->rx_mini_pending) || (ering->rx_jumbo_pending))
> + return -EINVAL;
Lots of unnecessary parenthesis, please remove.
> + if ((rx_count == rx_count_old) && (tx_count == tx_count_old))
> + return 0;
Likewise.
prev parent reply other threads:[~2017-08-14 2:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-12 1:28 [PATCH net-next 0/8] liquidio: adding support for ethtool --set-ring feature Felix Manlunas
2017-08-12 1:28 ` [PATCH net-next 1/8] liquidio: moved wait_for_pending_requests to octeon_network.h Felix Manlunas
2017-08-12 1:29 ` [PATCH net-next 2/8] liquidio: moved update_txq_status to lio_core.c Felix Manlunas
2017-08-12 1:29 ` [PATCH net-next 3/8] liquidio: moved octeon_setup_droq " Felix Manlunas
2017-08-12 1:29 ` [PATCH net-next 4/8] liquidio: moved liquidio_push_packet " Felix Manlunas
2017-08-12 1:29 ` [PATCH net-next 5/8] liquidio: moved liquidio_napi_drv_callback " Felix Manlunas
2017-08-12 1:29 ` [PATCH net-next 6/8] liquidio: moved liquidio_napi_poll " Felix Manlunas
2017-08-12 1:29 ` [PATCH net-next 7/8] liquidio: moved liquidio_setup_io_queues " Felix Manlunas
2017-08-12 1:29 ` [PATCH net-next 8/8] liquidio: added support for ethtool --set-ring feature Felix Manlunas
2017-08-14 2:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170813.194315.2299024672935275105.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=derek.chickles@cavium.com \
--cc=felix.manlunas@cavium.com \
--cc=intiyaz.basha@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@cavium.com \
--cc=satananda.burla@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).