From: David Miller <davem@davemloft.net>
To: jkbs@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] rtnelink: Move link dump consistency check out of the loop
Date: Sun, 13 Aug 2017 19:44:12 -0700 (PDT) [thread overview]
Message-ID: <20170813.194412.429768431959485148.davem@davemloft.net> (raw)
In-Reply-To: <20170809153912.19733-1-jkbs@redhat.com>
From: Jakub Sitnicki <jkbs@redhat.com>
Date: Wed, 9 Aug 2017 17:39:12 +0200
> Calls to rtnl_dump_ifinfo() are protected by RTNL lock. So are the
> {list,unlist}_netdevice() calls where we bump the net->dev_base_seq
> number.
>
> For this reason net->dev_base_seq can't change under out feet while
> we're looping over links in rtnl_dump_ifinfo(). So move the check for
> net->dev_base_seq change (since the last time we were called) out of the
> loop.
>
> This way we avoid giving a wrong impression that there are concurrent
> updates to the link list going on while we're iterating over them.
>
> Signed-off-by: Jakub Sitnicki <jkbs@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2017-08-14 2:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 15:39 [PATCH net-next] rtnelink: Move link dump consistency check out of the loop Jakub Sitnicki
2017-08-14 2:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170813.194412.429768431959485148.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jkbs@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).