* [PATCH net-next] net: ipv4: remove unnecessary check on orig_oif
@ 2017-08-12 0:02 David Ahern
2017-08-14 3:03 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: David Ahern @ 2017-08-12 0:02 UTC (permalink / raw)
To: netdev; +Cc: David Ahern
rt_iif is going to be set to either 0 or orig_oif. If orig_oif
is 0 it amounts to the same end result so remove the check.
Signed-off-by: David Ahern <dsahern@gmail.com>
---
net/ipv4/route.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 6324ade81a81..9c9895a6fc0f 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -2237,7 +2237,7 @@ static struct rtable *__mkroute_output(const struct fib_result *res,
if (!rth)
return ERR_PTR(-ENOBUFS);
- rth->rt_iif = orig_oif ? : 0;
+ rth->rt_iif = orig_oif;
if (res->table)
rth->rt_table_id = res->table->tb_id;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: ipv4: remove unnecessary check on orig_oif
2017-08-12 0:02 [PATCH net-next] net: ipv4: remove unnecessary check on orig_oif David Ahern
@ 2017-08-14 3:03 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-08-14 3:03 UTC (permalink / raw)
To: dsahern; +Cc: netdev
From: David Ahern <dsahern@gmail.com>
Date: Fri, 11 Aug 2017 17:02:02 -0700
> rt_iif is going to be set to either 0 or orig_oif. If orig_oif
> is 0 it amounts to the same end result so remove the check.
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied, thanks David.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-14 3:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-12 0:02 [PATCH net-next] net: ipv4: remove unnecessary check on orig_oif David Ahern
2017-08-14 3:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).