From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] tap: make struct tap_fops static Date: Sun, 13 Aug 2017 20:11:13 -0700 (PDT) Message-ID: <20170813.201113.1487220436668237112.davem@davemloft.net> References: <20170812215231.6272-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: sainath.grandhi@intel.com, jasowang@redhat.com, rolf.neugebauer@docker.com, willemb@google.com, zhangshengju@cmss.chinamobile.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: colin.king@canonical.com Return-path: In-Reply-To: <20170812215231.6272-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Colin King Date: Sat, 12 Aug 2017 22:52:31 +0100 > From: Colin Ian King > > The structure tap_fops is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'tap_fops' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Applied.