From: Leon Romanovsky <leon@kernel.org>
To: David Miller <davem@davemloft.net>
Cc: ohado@mellanox.com, netdev@vger.kernel.org, jiri@resnulli.us,
saeedm@mellanox.com, vadimp@mellanox.com,
system-sw-low-level@mellanox.com
Subject: Re: [patch v1 1/2] Allow Mellanox network vendor to be configured if only I2C bus is configured
Date: Mon, 14 Aug 2017 08:20:48 +0300 [thread overview]
Message-ID: <20170814052048.GC24282@mtr-leonro.local> (raw)
In-Reply-To: <20170813.172521.1720357048468458417.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1879 bytes --]
On Sun, Aug 13, 2017 at 05:25:21PM -0700, David Miller wrote:
> From: Ohad Oz <ohado@mellanox.com>
> Date: Sun, 13 Aug 2017 15:26:56 +0000
>
> >
> >
> >> -----Original Message-----
> >> From: Leon Romanovsky [mailto:leon@kernel.org]
> >> Sent: Saturday, August 12, 2017 5:37 PM
> >> To: Ohad Oz <ohado@mellanox.com>
> >> Cc: davem@davemloft.net; netdev@vger.kernel.org; jiri@resnulli.us; Saeed
> >> Mahameed <saeedm@mellanox.com>; Vadim Pasternak
> >> <vadimp@mellanox.com>; system-sw-low-level <system-sw-low-
> >> level@mellanox.com>
> >> Subject: Re: [patch v1 1/2] Allow Mellanox network vendor to be configured
> >> if only I2C bus is configured
> >>
> >> On Thu, Aug 10, 2017 at 05:11:51PM +0000, Ohad Oz wrote:
> >> > Patch allows Mellanox devices on system with no PCI, but with I2C only.
> >> >
> >>
> >> Did you test mlx5 device on such system? Did it work for you?
> >
> > Yes, I did. With PCI config set to disable mlx5 drivers are not built.
> > Only the following:
> > /build/drivers/net/Ethernet/mellanox/mlxsw/mlxsw_core.ko
> > /build/drivers/net/Ethernet/mellanox /mlxsw/mlxsw_i2c.ko
> > /build/drivers/net/Ethernet/mellanox /mlxsw/mlxsw_minimal.ko
> >
> > While with both options on all drivers are built inc mlx5.
>
> I'm not so sure he's interested if things build or not.
>
> He's asking you if you actually used a Mellanox device with this
> driver with PCI disabled and only I2C available.
Thanks David, you are absolutely right.
The commit message and more important, Kconfig entry, is misleading the potential
users by promising them that all devices under drivers/net/ethernet/mellanox
folder are working with i2c.
I have no technical objection to the idea of this patch, but it needs to be resubmitted after
Ohad ensures that mlx4/mlx5 are not visible in menuconfig for i2c
systems and he fixes Kconfig description together with commit log.
Thanks
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-14 5:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 17:11 [patch v1 1/2] Allow Mellanox network vendor to be configured if only I2C bus is configured Ohad Oz
2017-08-10 17:11 ` [patch v1 2/2] Change Kconfig description Ohad Oz
2017-08-12 14:37 ` [patch v1 1/2] Allow Mellanox network vendor to be configured if only I2C bus is configured Leon Romanovsky
2017-08-13 15:26 ` Ohad Oz
2017-08-14 0:25 ` David Miller
2017-08-14 5:20 ` Leon Romanovsky [this message]
2017-08-14 7:00 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170814052048.GC24282@mtr-leonro.local \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=ohado@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=system-sw-low-level@mellanox.com \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).