From: David Miller <davem@davemloft.net>
To: rdunlap@infradead.org
Cc: ncardwell@google.com, mohamed.a.alrshah@ieee.org,
netdev@vger.kernel.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, mothman@upm.edu.my,
borhan@upm.edu.my, zurinamh@upm.edu.my
Subject: Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile
Date: Tue, 15 Aug 2017 10:36:51 -0700 (PDT) [thread overview]
Message-ID: <20170815.103651.1877616739706523154.davem@davemloft.net> (raw)
In-Reply-To: <5fac1100-c7d3-85ed-8230-53e6ffb3df0a@infradead.org>
From: Randy Dunlap <rdunlap@infradead.org>
Date: Tue, 15 Aug 2017 09:41:53 -0700
> On 08/15/2017 06:51 AM, Neal Cardwell wrote:
>> On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah
>> <mohamed.a.alrshah@ieee.org> wrote:
>>
>>> +static void agilesdtcp_cong_avoid(struct sock *sk, u32 ack, u32 in_flight)
>>> +{
>>> + struct tcp_sock *tp = tcp_sk(sk);
>>> + struct agilesdtcp *ca = inet_csk_ca(sk);
>>> + u32 inc_factor;
>>> + u32 ca_inc;
>>> + u32 current_gap, total_gap;
>>
>> For coding style, please order local variable declarations from
>> longest to shortest line, also know as Reverse Christmas Tree Format.
>
> Per what coding style, please? This is not in current coding style nor in the
> netdev-FAQ exceptions.
It is the established practice, documented or not, and I enforce this for all
networking code submissions.
next prev parent reply other threads:[~2017-08-15 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 13:08 [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile mohamedalrshah
2017-08-15 13:51 ` Neal Cardwell
2017-08-15 16:41 ` Randy Dunlap
2017-08-15 17:36 ` David Miller [this message]
2017-08-15 17:50 ` Randy Dunlap
2017-08-15 14:01 ` Neal Cardwell
2017-08-15 17:10 ` Randy Dunlap
2017-08-16 23:36 ` kbuild test robot
2017-08-17 0:12 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815.103651.1877616739706523154.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=borhan@upm.edu.my \
--cc=linux-kernel@vger.kernel.org \
--cc=mohamed.a.alrshah@ieee.org \
--cc=mothman@upm.edu.my \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=zurinamh@upm.edu.my \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).