* [patch net-next] mlxsw: spectrum_router: Use correct config option
@ 2017-08-15 7:10 Jiri Pirko
2017-08-16 0:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Pirko @ 2017-08-15 7:10 UTC (permalink / raw)
To: netdev; +Cc: davem, idosch, mlxsw
From: Ido Schimmel <idosch@mellanox.com>
I made an embarrassing mistake and used 'IPV6' instead of 'CONFIG_IPV6'
around the function that updates the kernel about IPv6 neighbours
activity. This can be a problem if the kernel has more neighbours than a
certain threshold and it starts deleting those that are supposedly
inactive.
Fixes: b5f3e0d43012 ("mlxsw: spectrum_router: Fix build when IPv6 isn't enabled")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index 4895d5b..a0a9728 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -1042,7 +1042,7 @@ static void mlxsw_sp_router_neigh_ent_ipv4_process(struct mlxsw_sp *mlxsw_sp,
neigh_release(n);
}
-#if IS_ENABLED(IPV6)
+#if IS_ENABLED(CONFIG_IPV6)
static void mlxsw_sp_router_neigh_ent_ipv6_process(struct mlxsw_sp *mlxsw_sp,
char *rauhtd_pl,
int rec_index)
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch net-next] mlxsw: spectrum_router: Use correct config option
2017-08-15 7:10 [patch net-next] mlxsw: spectrum_router: Use correct config option Jiri Pirko
@ 2017-08-16 0:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-08-16 0:05 UTC (permalink / raw)
To: jiri; +Cc: netdev, idosch, mlxsw
From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 15 Aug 2017 09:10:33 +0200
> From: Ido Schimmel <idosch@mellanox.com>
>
> I made an embarrassing mistake and used 'IPV6' instead of 'CONFIG_IPV6'
> around the function that updates the kernel about IPv6 neighbours
> activity. This can be a problem if the kernel has more neighbours than a
> certain threshold and it starts deleting those that are supposedly
> inactive.
>
> Fixes: b5f3e0d43012 ("mlxsw: spectrum_router: Fix build when IPv6 isn't enabled")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Also applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-16 0:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-15 7:10 [patch net-next] mlxsw: spectrum_router: Use correct config option Jiri Pirko
2017-08-16 0:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).