From: David Miller <davem@davemloft.net>
To: khlebnikov@yandex-team.ru
Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com,
jiri@mellanox.com, jhs@mojatatu.com
Subject: Re: [PATCH] net_sched: reset pointers to tcf blocks in classful qdiscs' destructors
Date: Tue, 15 Aug 2017 17:16:55 -0700 (PDT) [thread overview]
Message-ID: <20170815.171655.845249059396512148.davem@davemloft.net> (raw)
In-Reply-To: <150280412126.717517.16274927544808177918.stgit@buzz>
From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Date: Tue, 15 Aug 2017 16:35:21 +0300
> Traffic filters could keep direct pointers to classes in classful qdisc,
> thus qdisc destruction first removes all filters before freeing classes.
> Class destruction methods also tries to free attached filters but now
> this isn't safe because tcf_block_put() unlike to tcf_destroy_chain()
> cannot be called second time.
>
> This patch set class->block to NULL after first tcf_block_put() and
> turn second call into no-op.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure")
Applied and queued up for -stable.
prev parent reply other threads:[~2017-08-16 0:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 13:35 [PATCH] net_sched: reset pointers to tcf blocks in classful qdiscs' destructors Konstantin Khlebnikov
2017-08-15 14:00 ` Jiri Pirko
2017-08-16 0:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815.171655.845249059396512148.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=khlebnikov@yandex-team.ru \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).