From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
hideaki.yoshifuji@miraclelinux.com, glider@google.com,
dvyukov@google.com, kcc@google.com, edumazet@google.com,
lucien.xin@gmail.com, vyasevich@gmail.com,
linux-kernel@vger.kernel.org, linux-sctp@vger.kernel.org,
netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH v2] sctp: fully initialize the IPv6 address in sctp_v6_to_addr()
Date: Tue, 15 Aug 2017 13:31:41 -0300 [thread overview]
Message-ID: <20170815163141.GD18688@localhost.localdomain> (raw)
In-Reply-To: <1502811469.4936.84.camel@edumazet-glaptop3.roam.corp.google.com>
On Tue, Aug 15, 2017 at 08:37:49AM -0700, Eric Dumazet wrote:
> On Tue, 2017-08-15 at 12:05 -0300, Marcelo Ricardo Leitner wrote:
>
> > Ok, but I should see a difference in the generated code, right?
>
> Depends on the compiler. Have you tried older versions ?
>
This was with gcc 6.4.1, fc25 standard. Only tested with it and didn't
check clang either.
> One argument is that following struct member definition eases code
> review.
>
> (It is easier to catch a field init is missing)
And a good one, yes.
Thanks,
Marcelo
prev parent reply other threads:[~2017-08-15 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 18:43 [PATCH v2] sctp: fully initialize the IPv6 address in sctp_v6_to_addr() Alexander Potapenko
2017-08-14 23:07 ` Marcelo Ricardo Leitner
2017-08-15 1:43 ` 吉藤英明
2017-08-15 1:58 ` Marcelo Ricardo Leitner
2017-08-15 2:40 ` David Miller
2017-08-15 15:05 ` Marcelo Ricardo Leitner
2017-08-15 15:37 ` Eric Dumazet
2017-08-15 16:31 ` Marcelo Ricardo Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815163141.GD18688@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=glider@google.com \
--cc=hideaki.yoshifuji@miraclelinux.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevich@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).