From: David Miller <davem@davemloft.net>
To: khlebnikov@yandex-team.ru
Cc: netdev@vger.kernel.org, xiyou.wangcong@gmail.com,
jkosina@suse.cz, edumazet@google.com, jhs@mojatatu.com
Subject: Re: [PATCH 1/2] net_sched: call qlen_notify only if child qdisc is empty
Date: Wed, 16 Aug 2017 10:56:57 -0700 (PDT) [thread overview]
Message-ID: <20170816.105657.1279204691313415545.davem@davemloft.net> (raw)
In-Reply-To: <150280439968.717891.6476652519937001709.stgit@buzz>
From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Date: Tue, 15 Aug 2017 16:39:59 +0300
> This callback is used for deactivating class in parent qdisc.
> This is cheaper to test queue length right here.
>
> Also this allows to catch draining screwed backlog and prevent
> second deactivation of already inactive parent class which will
> crash kernel for sure. Kernel with print warning at destruction
> of child qdisc where no packets but backlog is not zero.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Applied.
prev parent reply other threads:[~2017-08-16 17:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 13:39 [PATCH 1/2] net_sched: call qlen_notify only if child qdisc is empty Konstantin Khlebnikov
2017-08-15 13:40 ` [PATCH 2/2] net_sched/hfsc: opencode trivial set_active() and set_passive() Konstantin Khlebnikov
2017-08-16 17:57 ` David Miller
2017-08-16 17:22 ` [PATCH 1/2] net_sched: call qlen_notify only if child qdisc is empty Cong Wang
2017-08-16 17:32 ` Konstantin Khlebnikov
2017-08-16 17:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816.105657.1279204691313415545.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jkosina@suse.cz \
--cc=khlebnikov@yandex-team.ru \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).