Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: decui@microsoft.com
Cc: netdev@vger.kernel.org, gregkh@linuxfoundation.org,
	devel@linuxdriverproject.org, kys@microsoft.com,
	haiyangz@microsoft.com, sthemmin@microsoft.com,
	georgezhang@vmware.com, jhansen@vmware.com, mkubecek@suse.cz,
	asias@redhat.com, stefanha@redhat.com, vkuznets@redhat.com,
	cavery@redhat.com, jasowang@redhat.com,
	rolf.neugebauer@docker.com, dave.scott@docker.com,
	marcelo.cerri@canonical.com, apw@canonical.com, olaf@aepfle.de,
	joe@perches.com, linux-kernel@vger.kernel.org,
	dan.carpenter@oracle.com
Subject: Re: [PATCH net-next 1/3] VMCI: only load on VMware hypervisor
Date: Wed, 16 Aug 2017 11:06:35 -0700 (PDT)	[thread overview]
Message-ID: <20170816.110635.1062040564700704290.davem@davemloft.net> (raw)
In-Reply-To: <KL1P15301MB00083C97259FF2A700C78442BF8D0@KL1P15301MB0008.APCP153.PROD.OUTLOOK.COM>

From: Dexuan Cui <decui@microsoft.com>
Date: Tue, 15 Aug 2017 22:13:29 +0000

> +	/*
> +	 * Check if we are running on VMware's hypervisor and bail out
> +	 * if we are not.
> +	 */
> +	if (x86_hyper != &x86_hyper_vmware)
> +		return -ENODEV;

This symbol is only available when CONFIG_HYPERVISOR_GUEST is defined.
But this driver does not have a Kconfig dependency on that symbol so
the build can fail in some configurations.

  reply	other threads:[~2017-08-16 18:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15 22:13 [PATCH net-next 1/3] VMCI: only load on VMware hypervisor Dexuan Cui
2017-08-16 18:06 ` David Miller [this message]
2017-08-16 18:51   ` Dexuan Cui
2017-08-16 18:54     ` David Miller
2017-08-16 19:44 ` Jorgen S. Hansen
2017-08-16 22:33   ` Dexuan Cui
2017-08-17  8:10     ` Dexuan Cui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170816.110635.1062040564700704290.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=apw@canonical.com \
    --cc=asias@redhat.com \
    --cc=cavery@redhat.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dave.scott@docker.com \
    --cc=decui@microsoft.com \
    --cc=devel@linuxdriverproject.org \
    --cc=georgezhang@vmware.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haiyangz@microsoft.com \
    --cc=jasowang@redhat.com \
    --cc=jhansen@vmware.com \
    --cc=joe@perches.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.cerri@canonical.com \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=rolf.neugebauer@docker.com \
    --cc=stefanha@redhat.com \
    --cc=sthemmin@microsoft.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox