From: David Miller <davem@davemloft.net>
To: brouer@redhat.com
Cc: netdev@vger.kernel.org, pstaszewski@itcare.pl
Subject: Re: [PATCH] qdisc: add tracepoint qdisc:qdisc_dequeue for dequeued SKBs
Date: Wed, 16 Aug 2017 14:09:47 -0700 (PDT) [thread overview]
Message-ID: <20170816.140947.570761977406039647.davem@davemloft.net> (raw)
In-Reply-To: <150282426296.20350.8045788556432194444.stgit@firesoul>
From: Jesper Dangaard Brouer <brouer@redhat.com>
Date: Tue, 15 Aug 2017 21:11:03 +0200
> The main purpose of this tracepoint is to monitor bulk dequeue
> in the network qdisc layer, as it cannot be deducted from the
> existing qdisc stats.
>
> The txq_state can be used for determining the reason for zero packet
> dequeues, see enum netdev_queue_state_t.
>
> Notice all packets doesn't necessary activate this tracepoint. As
> qdiscs with flag TCQ_F_CAN_BYPASS, can directly invoke
> sch_direct_xmit() when qdisc_qlen is zero.
>
> Remember that perf record supports filters like:
>
> perf record -e qdisc:qdisc_dequeue \
> --filter 'ifindex == 4 && (packets > 1 || txq_state > 0)'
>
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
I'll apply this to net-next, thanks Jesper.
prev parent reply other threads:[~2017-08-16 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 19:11 [PATCH] qdisc: add tracepoint qdisc:qdisc_dequeue for dequeued SKBs Jesper Dangaard Brouer
2017-08-16 2:31 ` David Ahern
2017-08-16 5:15 ` Jesper Dangaard Brouer
2017-08-16 21:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816.140947.570761977406039647.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brouer@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pstaszewski@itcare.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).