From: David Miller <davem@davemloft.net>
To: decui@microsoft.com
Cc: mkubecek@suse.cz, jasowang@redhat.com, georgezhang@vmware.com,
sthemmin@microsoft.com, rolf.neugebauer@docker.com,
marcelo.cerri@canonical.com, asias@redhat.com,
dan.carpenter@oracle.com, olaf@aepfle.de, haiyangz@microsoft.com,
dave.scott@docker.com, stefanha@redhat.com, apw@canonical.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, joe@perches.com,
devel@linuxdriverproject.org, vkuznets@redhat.com,
jhansen@vmware.com
Subject: Re: [PATCH] vsock: only load vmci transport on VMware hypervisor by default
Date: Thu, 17 Aug 2017 10:04:01 -0700 (PDT) [thread overview]
Message-ID: <20170817.100401.864010589587308706.davem@davemloft.net> (raw)
In-Reply-To: <KL1P15301MB0008F70D4E5248AB7A296CE3BF830@KL1P15301MB0008.APCP153.PROD.OUTLOOK.COM>
From: Dexuan Cui <decui@microsoft.com>
Date: Thu, 17 Aug 2017 08:00:29 +0000
> @@ -73,6 +74,10 @@ struct vmci_transport_recv_pkt_info {
> struct vmci_transport_packet pkt;
> };
>
> +static bool skip_hypervisor_check;
> +module_param(skip_hypervisor_check, bool, 0444);
> +MODULE_PARM_DESC(hot_add, "If set, attempt to load on non-VMware platforms");
> +
I would avoid module parameters at all costs.
It is the worst possible interface for users of your software.
You really need to fundamentally solve the problems related to making
sure the proper modules for the VM actually present on the system get
loaded when necessary rather than adding hacks like this.
Unlike a proper solution, these hacks are ugly but have to stay around
forever once you put them in place.
next prev parent reply other threads:[~2017-08-17 17:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 8:00 [PATCH] vsock: only load vmci transport on VMware hypervisor by default Dexuan Cui
2017-08-17 13:55 ` Stefan Hajnoczi
2017-08-17 15:16 ` Jorgen S. Hansen
2017-08-18 3:07 ` Dexuan Cui
2017-08-18 15:37 ` Stefan Hajnoczi
2017-08-18 23:07 ` Dexuan Cui
2017-08-22 9:54 ` Stefan Hajnoczi
2017-08-22 13:07 ` Jorgen S. Hansen
2017-08-23 4:21 ` Dexuan Cui
2017-08-29 2:36 ` Dexuan Cui
2017-08-29 15:37 ` Jorgen S. Hansen
2017-08-31 11:54 ` Stefan Hajnoczi
2017-09-02 6:25 ` Dexuan Cui
2017-09-06 14:11 ` Jorgen S. Hansen
2017-09-06 19:39 ` Dexuan Cui
2017-08-17 17:04 ` David Miller [this message]
2017-08-17 18:27 ` Dexuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817.100401.864010589587308706.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=apw@canonical.com \
--cc=asias@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=dave.scott@docker.com \
--cc=decui@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=georgezhang@vmware.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=jhansen@vmware.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=rolf.neugebauer@docker.com \
--cc=stefanha@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox