From: David Miller <davem@davemloft.net>
To: andrew@lunn.ch
Cc: thomas.lendacky@amd.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 05/14] amd-xgbe: Add additional debugfs support
Date: Thu, 17 Aug 2017 22:02:03 -0700 (PDT) [thread overview]
Message-ID: <20170817.220203.1607309698344574831.davem@davemloft.net> (raw)
In-Reply-To: <20170818003057.GA11030@lunn.ch>
From: Andrew Lunn <andrew@lunn.ch>
Date: Fri, 18 Aug 2017 02:30:57 +0200
> On Thu, Aug 17, 2017 at 07:02:50PM -0500, Tom Lendacky wrote:
>> Add additional debugfs support for reading / writing registers of any
>> attached external phy devices as well as the SFP eeprom data.
>
> Hi Tom
>
> What is wrong with using the standard APIs for this?
>
> ethtool --moduile-info
>
> ioctls SIOCGMIIREG and SIOCSMIIREG.
Yeah debugfs is a horrible choice for this.
debugfs in general should be strongly avoided. We have rich eneough
facilities to export just about anything that is actually appropriate
and useful, and where we do not existing facilities should be extended
as needed rather than ignored.
next prev parent reply other threads:[~2017-08-18 5:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 0:02 [PATCH net-next v1 00/14] amd-xgbe: AMD XGBE driver updates 2017-08-17 Tom Lendacky
2017-08-18 0:02 ` [PATCH net-next v1 01/14] amd-xgbe: Set the MDIO mode for 10000Base-T configuration Tom Lendacky
2017-08-18 0:02 ` [PATCH net-next v1 02/14] amd-xgbe: Set the MII control width for the MAC interface Tom Lendacky
2017-08-18 0:02 ` [PATCH net-next v1 03/14] amd-xgbe: Be sure driver shuts down cleanly on module removal Tom Lendacky
2017-08-18 0:02 ` [PATCH net-next v1 04/14] amd-xgbe: Update TSO packet statistics accuracy Tom Lendacky
2017-08-18 0:02 ` [PATCH net-next v1 05/14] amd-xgbe: Add additional debugfs support Tom Lendacky
2017-08-18 0:30 ` Andrew Lunn
2017-08-18 5:02 ` David Miller [this message]
2017-08-18 12:58 ` Tom Lendacky
2017-08-18 0:02 ` [PATCH net-next v1 06/14] amd-xgbe: Add support to handle device renaming Tom Lendacky
2017-08-18 0:03 ` [PATCH net-next v1 07/14] amd-xgbe: Add additional dynamic debug messages Tom Lendacky
2017-08-18 0:03 ` [PATCH net-next v1 08/14] amd-xgbe: Optimize DMA channel interrupt enablement Tom Lendacky
2017-08-18 0:03 ` [PATCH net-next v1 09/14] amd-xgbe: Add hardware features debug output Tom Lendacky
2017-08-18 0:03 ` [PATCH net-next v1 10/14] amd-xgbe: Add per queue Tx and Rx statistics Tom Lendacky
2017-08-18 0:03 ` [PATCH net-next v1 11/14] net: ethtool: Add macro to clear a link mode setting Tom Lendacky
2017-08-18 0:03 ` [PATCH net-next v1 12/14] amd-xgbe: Convert to using the new link mode settings Tom Lendacky
2017-08-18 0:04 ` [PATCH net-next v1 13/14] amd-xgbe: Add support for VXLAN offload capabilities Tom Lendacky
2017-08-18 0:04 ` [PATCH net-next v1 14/14] amd-xgbe: Add additional ethtool statistics Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817.220203.1607309698344574831.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).