From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: aviad.krawczyk@huawei.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, bc.y@huawei.com,
victor.gissin@huawei.com, zhaochen6@huawei.com,
tony.qu@huawei.com
Subject: Re: [PATCH V5 net-next 01/21] net-next/hinic: Initialize hw interface
Date: Thu, 17 Aug 2017 22:03:58 -0700 (PDT) [thread overview]
Message-ID: <20170817.220358.1098888253167010337.davem@davemloft.net> (raw)
In-Reply-To: <20170817174540.46986450@xeon-e3>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 17 Aug 2017 17:45:40 -0700
> On Thu, 17 Aug 2017 19:52:42 +0800
> Aviad Krawczyk <aviad.krawczyk@huawei.com> wrote:
>
>> + nic_dev = (struct hinic_dev *)netdev_priv(netdev);
>
> Since netdev_priv() returns void *, a cast is not necessary here.
Agreed.
next prev parent reply other threads:[~2017-08-18 5:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 11:52 [PATCH V5 net-next 00/21] Huawei HiNIC Ethernet Driver Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 01/21] net-next/hinic: Initialize hw interface Aviad Krawczyk
2017-08-18 0:42 ` Stephen Hemminger
2017-08-18 5:03 ` David Miller
2017-08-18 0:45 ` Stephen Hemminger
2017-08-18 5:03 ` David Miller [this message]
2017-08-20 9:20 ` Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 02/21] net-next/hinic: Initialize hw device components Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 03/21] net-next/hinic: Initialize api cmd resources Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 04/21] net-next/hinic: Initialize api cmd hw Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 05/21] net-next/hinic: Add management messages Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 06/21] net-next/hinic: Add api cmd commands Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 07/21] net-next/hinic: Add aeqs Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 08/21] net-next/hinic: Add port management commands Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 09/21] net-next/hinic: Add Rx mode and link event handler Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 10/21] net-next/hinic: Add logical Txq and Rxq Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 11/21] net-next/hinic: Add wq Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 12/21] net-next/hinic: Add qp resources Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 13/21] net-next/hinic: Set qp context Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 14/21] net-next/hinic: Initialize cmdq Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 15/21] net-next/hinic: Add ceqs Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 16/21] net-next/hinic: Add cmdq commands Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 17/21] net-next/hinic: Add cmdq completion handler Aviad Krawczyk
2017-08-17 11:52 ` [PATCH V5 net-next 18/21] net-next/hinic: Add Rx handler Aviad Krawczyk
2017-08-17 11:53 ` [PATCH V5 net-next 19/21] net-next/hinic: Add Tx operation Aviad Krawczyk
2017-08-17 11:53 ` [PATCH V5 net-next 20/21] net-next/hinic: Add ethtool and stats Aviad Krawczyk
2017-08-17 11:53 ` [PATCH V5 net-next 21/21] net-next/hinic: Add netpoll Aviad Krawczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817.220358.1098888253167010337.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aviad.krawczyk@huawei.com \
--cc=bc.y@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=tony.qu@huawei.com \
--cc=victor.gissin@huawei.com \
--cc=zhaochen6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).