From: Phil Sutter <phil@nwl.cc>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: [iproute PATCH v2 6/7] netem/maketable: Check return value of fstat()
Date: Thu, 17 Aug 2017 19:09:30 +0200 [thread overview]
Message-ID: <20170817170931.24302-7-phil@nwl.cc> (raw)
In-Reply-To: <20170817170931.24302-1-phil@nwl.cc>
Otherwise info.st_size may contain garbage.
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
netem/maketable.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/netem/maketable.c b/netem/maketable.c
index 6aff927be7040..ad660e7d457f0 100644
--- a/netem/maketable.c
+++ b/netem/maketable.c
@@ -24,8 +24,8 @@ readdoubles(FILE *fp, int *number)
int limit;
int n=0, i;
- fstat(fileno(fp), &info);
- if (info.st_size > 0) {
+ if (!fstat(fileno(fp), &info) &&
+ info.st_size > 0) {
limit = 2*info.st_size/sizeof(double); /* @@ approximate */
} else {
limit = 10000;
--
2.13.1
next prev parent reply other threads:[~2017-08-17 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 17:09 [iproute PATCH v2 0/7] Covscan: Don't access garbage Phil Sutter
2017-08-17 17:09 ` [iproute PATCH v2 1/7] ipaddress: Make buffer for filter.flushb static Phil Sutter
2017-08-18 11:57 ` Phil Sutter
2017-08-18 15:55 ` Stephen Hemminger
2017-08-17 17:09 ` [iproute PATCH v2 2/7] ipaddress: Avoid accessing uninitialized variable lcl Phil Sutter
2017-08-17 17:09 ` [iproute PATCH v2 3/7] iplink_can: Prevent overstepping array bounds Phil Sutter
2017-08-17 17:09 ` [iproute PATCH v2 4/7] ipmaddr: Avoid accessing uninitialized data Phil Sutter
2017-08-17 17:09 ` [iproute PATCH v2 5/7] ss: Use C99 initializer in netlink_show_one() Phil Sutter
2017-08-17 17:09 ` Phil Sutter [this message]
2017-08-17 17:09 ` [iproute PATCH v2 7/7] tc/q_multiq: Don't pass garbage in TCA_OPTIONS Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817170931.24302-7-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).