* [PATCH] irda: do not leak initialized list.dev to userspace
@ 2017-08-17 22:14 Colin King
2017-08-18 23:22 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-08-17 22:14 UTC (permalink / raw)
To: netdev; +Cc: Samuel Ortiz, David S . Miller, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
list.dev has not been initialized and so the copy_to_user is copying
data from the stack back to user space which is a potential
information leak. Fix this ensuring all of list is initialized to
zero.
Detected by CoverityScan, CID#1357894 ("Uninitialized scalar variable")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/irda/af_irda.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/irda/af_irda.c b/net/irda/af_irda.c
index 2e6990f8b80b..23fa7c8b09a5 100644
--- a/net/irda/af_irda.c
+++ b/net/irda/af_irda.c
@@ -2213,7 +2213,7 @@ static int irda_getsockopt(struct socket *sock, int level, int optname,
{
struct sock *sk = sock->sk;
struct irda_sock *self = irda_sk(sk);
- struct irda_device_list list;
+ struct irda_device_list list = { 0 };
struct irda_device_info *discoveries;
struct irda_ias_set * ias_opt; /* IAS get/query params */
struct ias_object * ias_obj; /* Object in IAS */
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] irda: do not leak initialized list.dev to userspace
2017-08-17 22:14 [PATCH] irda: do not leak initialized list.dev to userspace Colin King
@ 2017-08-18 23:22 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-08-18 23:22 UTC (permalink / raw)
To: colin.king; +Cc: netdev, samuel, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 17 Aug 2017 23:14:58 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> list.dev has not been initialized and so the copy_to_user is copying
> data from the stack back to user space which is a potential
> information leak. Fix this ensuring all of list is initialized to
> zero.
>
> Detected by CoverityScan, CID#1357894 ("Uninitialized scalar variable")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-18 23:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-17 22:14 [PATCH] irda: do not leak initialized list.dev to userspace Colin King
2017-08-18 23:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).