From: David Miller <davem@davemloft.net>
To: john.fastabend@gmail.com
Cc: daniel@iogearbox.net, netdev@vger.kernel.org
Subject: Re: [net-next PATCH] net: rcu lock and preempt disable missing around generic xdp
Date: Fri, 18 Aug 2017 16:04:59 -0700 (PDT) [thread overview]
Message-ID: <20170818.160459.1790177371740031034.davem@davemloft.net> (raw)
In-Reply-To: <20170816183319.7709.87749.stgit@john-Precision-Tower-5810>
From: John Fastabend <john.fastabend@gmail.com>
Date: Wed, 16 Aug 2017 11:33:19 -0700
> do_xdp_generic must be called inside rcu critical section with preempt
> disabled to ensure BPF programs are valid and per-cpu variables used
> for redirect operations are consistent. This patch ensures this is true
> and fixes the splat below.
>
> The netif_receive_skb_internal() code path is now broken into two rcu
> critical sections. I decided it was better to limit the preempt_enable/disable
> block to just the xdp static key portion and the fallout is more
> rcu_read_lock/unlock calls. Seems like the best option to me.
...
> Fixes: d445516966dc ("net: xdp: support xdp generic on virtual devices")
> Fixes: b5cdae3291f7 ("net: Generic XDP")
> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
John you'll need to respin this as these code blocks have changed.
prev parent reply other threads:[~2017-08-18 23:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 18:33 [net-next PATCH] net: rcu lock and preempt disable missing around generic xdp John Fastabend
2017-08-18 23:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818.160459.1790177371740031034.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox