From: David Miller <davem@davemloft.net>
To: roopa@cumulusnetworks.com
Cc: netdev@vger.kernel.org, fw@strlen.de, dsa@cumulusnetworks.com,
idaifish@gmail.com, syzkaller@googlegroups.com,
dvyukov@google.com, eric.dumazet@gmail.com
Subject: Re: [PATCH net v2] net: check and errout if res->fi is NULL when RTM_F_FIB_MATCH is set
Date: Fri, 18 Aug 2017 16:06:23 -0700 (PDT) [thread overview]
Message-ID: <20170818.160623.1816130769638429758.davem@davemloft.net> (raw)
In-Reply-To: <1502912332-41154-1-git-send-email-roopa@cumulusnetworks.com>
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Date: Wed, 16 Aug 2017 12:38:52 -0700
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> Syzkaller hit 'general protection fault in fib_dump_info' bug on
> commit 4.13-rc5..
>
> Guilty file: net/ipv4/fib_semantics.c
...
> This patch adds a res->fi NULL check.
>
> example run:
> $ip route get 0.0.0.0 iif virt1-0
> broadcast 0.0.0.0 dev lo
> cache <local,brd> iif virt1-0
>
> $ip route get 0.0.0.0 iif virt1-0 fibmatch
> RTNETLINK answers: No route to host
>
> Reported-by: idaifish <idaifish@gmail.com>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Fixes: b61798130f1b ("net: ipv4: RTM_GETROUTE: return matched fib result when requested")
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Applied, thank you.
prev parent reply other threads:[~2017-08-18 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 19:38 [PATCH net v2] net: check and errout if res->fi is NULL when RTM_F_FIB_MATCH is set Roopa Prabhu
2017-08-18 23:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818.160623.1816130769638429758.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=dvyukov@google.com \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=idaifish@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox