From: David Miller <davem@davemloft.net>
To: ganeshgr@chelsio.com
Cc: netdev@vger.kernel.org, nirranjan@chelsio.com,
indranil@chelsio.com, leedom@chelsio.com, venkatesh@chelsio.com
Subject: Re: [PATCH net-next] cxgb4/cxgbvf: Handle 32-bit fw port capabilities
Date: Sat, 19 Aug 2017 21:34:30 -0700 (PDT) [thread overview]
Message-ID: <20170819.213430.892558113817773681.davem@davemloft.net> (raw)
In-Reply-To: <20170819.213240.451867452734302860.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Sat, 19 Aug 2017 21:32:40 -0700 (PDT)
> From: Ganesh Goudar <ganeshgr@chelsio.com>
> Date: Fri, 18 Aug 2017 21:21:32 +0530
>
>> Implement new 32-bit Firmware Port Capabilities in order to
>> handle new speeds which couldn't be represented in the old 16-bit
>> Firmware Port Capabilities values.
>>
>> Based on the original work of Casey Leedom <leedom@chelsio.com>
>>
>> Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
>
> Applied.
Reverted, this doesn't even build!
[davem@localhost net-next]$ make -s -j8
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c: In function ‘fwevtq_handler’:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:534:50: error: expected ‘)’ before ‘{’ token
action == FW_PORT_ACTION_GET_PORT_INFO32) {
^
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:560:2: error: expected expression before ‘}’ token
} else if (opcode == CPL_L2T_WRITE_RPL) {
^
At top level:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:463:13: warning: ‘dcb_rpl’ defined but not used [-Wunused-function]
static void dcb_rpl(struct adapter *adap, const struct fw_port_cmd *pcmd)
^~~~~~~
make[5]: *** [scripts/Makefile.build:303: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [scripts/Makefile.build:561: drivers/net/ethernet/chelsio/cxgb4] Error 2
make[3]: *** [scripts/Makefile.build:561: drivers/net/ethernet/chelsio] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [scripts/Makefile.build:561: drivers/net/ethernet] Error 2
make[1]: *** [scripts/Makefile.build:561: drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1019: drivers] Error 2
prev parent reply other threads:[~2017-08-20 4:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 15:51 [PATCH net-next] cxgb4/cxgbvf: Handle 32-bit fw port capabilities Ganesh Goudar
2017-08-20 4:32 ` David Miller
2017-08-20 4:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170819.213430.892558113817773681.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ganeshgr@chelsio.com \
--cc=indranil@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=venkatesh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox