[net-next:master 1184/1189] include/linux/bpf.h:324:21: error: 'NUMA_NO_NODE' undeclared

[net-next:master 1184/1189] include/linux/bpf.h:324:21: error: 'NUMA_NO_NODE' undeclared

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1973 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   228498596c44041c710f5a633904205bc1cd9177
commit: 96eabe7a40aa17e613cf3db2c742ee8b1fc764d0 [1184/1189] bpf: Allow selecting numa node during map creation
config: i386-randconfig-s1-201734 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout 96eabe7a40aa17e613cf3db2c742ee8b1fc764d0
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from net/bpf/test_run.c:7:0:
   include/linux/bpf.h: In function 'bpf_map_attr_numa_node':
>> include/linux/bpf.h:324:21: error: 'NUMA_NO_NODE' undeclared (first use in this function)
      attr->numa_node : NUMA_NO_NODE;
                        ^~~~~~~~~~~~
   include/linux/bpf.h:324:21: note: each undeclared identifier is reported only once for each function it appears in
--
   In file included from kernel/bpf/syscall.c:12:0:
   include/linux/bpf.h: In function 'bpf_map_attr_numa_node':
>> include/linux/bpf.h:324:21: error: 'NUMA_NO_NODE' undeclared (first use in this function)
      attr->numa_node : NUMA_NO_NODE;
                        ^~~~~~~~~~~~
   include/linux/bpf.h:324:21: note: each undeclared identifier is reported only once for each function it appears in
   In file included from kernel/bpf/syscall.c:12:0:
>> include/linux/bpf.h:325:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +/NUMA_NO_NODE +324 include/linux/bpf.h

   319	
   320	/* Return map's numa specified by userspace */
   321	static inline int bpf_map_attr_numa_node(const union bpf_attr *attr)
   322	{
   323		return (attr->map_flags & BPF_F_NUMA_NODE) ?
 > 324			attr->numa_node : NUMA_NO_NODE;
 > 325	}
   326	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23968 bytes --]

Re: [net-next:master 1184/1189] include/linux/bpf.h:324:21: error: 'NUMA_NO_NODE' undeclared

[Martin KaFai Lau]

On Sun, Aug 20, 2017 at 01:43:54PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
> head:   228498596c44041c710f5a633904205bc1cd9177
> commit: 96eabe7a40aa17e613cf3db2c742ee8b1fc764d0 [1184/1189] bpf: Allow selecting numa node during map creation
> config: i386-randconfig-s1-201734 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         git checkout 96eabe7a40aa17e613cf3db2c742ee8b1fc764d0
>         # save the attached .config to linux build tree
>         make ARCH=i386
>
> All error/warnings (new ones prefixed by >>):
>
>    In file included from net/bpf/test_run.c:7:0:
>    include/linux/bpf.h: In function 'bpf_map_attr_numa_node':
> >> include/linux/bpf.h:324:21: error: 'NUMA_NO_NODE' undeclared (first use in this function)
>       attr->numa_node : NUMA_NO_NODE;
>                         ^~~~~~~~~~~~
>    include/linux/bpf.h:324:21: note: each undeclared identifier is reported only once for each function it appears in
> --
>    In file included from kernel/bpf/syscall.c:12:0:
>    include/linux/bpf.h: In function 'bpf_map_attr_numa_node':
> >> include/linux/bpf.h:324:21: error: 'NUMA_NO_NODE' undeclared (first use in this function)
>       attr->numa_node : NUMA_NO_NODE;
>                         ^~~~~~~~~~~~
>    include/linux/bpf.h:324:21: note: each undeclared identifier is reported only once for each function it appears in
>    In file included from kernel/bpf/syscall.c:12:0:
> >> include/linux/bpf.h:325:1: warning: control reaches end of non-void function [-Wreturn-type]
>     }
>     ^
I will post a fix shortly.

>
> vim +/NUMA_NO_NODE +324 include/linux/bpf.h
>
>    319
>    320	/* Return map's numa specified by userspace */
>    321	static inline int bpf_map_attr_numa_node(const union bpf_attr *attr)
>    322	{
>    323		return (attr->map_flags & BPF_F_NUMA_NODE) ?
>  > 324			attr->numa_node : NUMA_NO_NODE;
>  > 325	}
>    326
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.01.org_pipermail_kbuild-2Dall&d=DwIBAg&c=5VD0RTtNlTh3ycd41b3MUw&r=VQnoQ7LvghIj0gVEaiQSUw&m=36OvwN5FPWpOV3AefLVno0fEHrg6mcU_F6ErzV-KPlc&s=EDsqfhvtP3I95wiIrIqYE8CEAk6wnfUAuVWkCb3iXP4&e=                    Intel Corporation

Re: [net-next:master 1184/1189] include/linux/bpf.h:324:21: error: 'NUMA_NO_NODE' undeclared

[David Miller]

From: kbuild test robot <fengguang.wu@intel.com>
Date: Sun, 20 Aug 2017 13:43:54 +0800

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
> head:   228498596c44041c710f5a633904205bc1cd9177
> commit: 96eabe7a40aa17e613cf3db2c742ee8b1fc764d0 [1184/1189] bpf: Allow selecting numa node during map creation
> config: i386-randconfig-s1-201734 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         git checkout 96eabe7a40aa17e613cf3db2c742ee8b1fc764d0
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All error/warnings (new ones prefixed by >>):
> 
>    In file included from net/bpf/test_run.c:7:0:
>    include/linux/bpf.h: In function 'bpf_map_attr_numa_node':
>>> include/linux/bpf.h:324:21: error: 'NUMA_NO_NODE' undeclared (first use in this function)
>       attr->numa_node : NUMA_NO_NODE;
>                         ^~~~~~~~~~~~

I'll add the linux/numa.h include to linux/bpf.h

Re: [net-next:master 1184/1189] include/linux/bpf.h:324:21: error: 'NUMA_NO_NODE' undeclared

[Martin KaFai Lau]

On Sat, Aug 19, 2017 at 11:33:13PM -0700, David Miller wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
> Date: Sun, 20 Aug 2017 13:43:54 +0800
>
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
> > head:   228498596c44041c710f5a633904205bc1cd9177
> > commit: 96eabe7a40aa17e613cf3db2c742ee8b1fc764d0 [1184/1189] bpf: Allow selecting numa node during map creation
> > config: i386-randconfig-s1-201734 (attached as .config)
> > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> > reproduce:
> >         git checkout 96eabe7a40aa17e613cf3db2c742ee8b1fc764d0
> >         # save the attached .config to linux build tree
> >         make ARCH=i386
> >
> > All error/warnings (new ones prefixed by >>):
> >
> >    In file included from net/bpf/test_run.c:7:0:
> >    include/linux/bpf.h: In function 'bpf_map_attr_numa_node':
> >>> include/linux/bpf.h:324:21: error: 'NUMA_NO_NODE' undeclared (first use in this function)
> >       attr->numa_node : NUMA_NO_NODE;
> >                         ^~~~~~~~~~~~
>
> I'll add the linux/numa.h include to linux/bpf.h
Thanks for fixing it.  Sorry for the mistake.