* [PATCH] tools lib bpf: improve warning
@ 2017-08-20 19:48 Eric Leblond
2017-08-20 21:45 ` Daniel Borkmann
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Eric Leblond @ 2017-08-20 19:48 UTC (permalink / raw)
To: netdev; +Cc: Eric Leblond
Signed-off-by: Eric Leblond <eric@regit.org>
---
tools/lib/bpf/libbpf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 1cc3ea0ffdc3..35f6dfcdc565 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -879,7 +879,8 @@ bpf_object__create_maps(struct bpf_object *obj)
size_t j;
int err = *pfd;
- pr_warning("failed to create map: %s\n",
+ pr_warning("failed to create map (name: '%s'): %s\n",
+ obj->maps[i].name,
strerror(errno));
for (j = 0; j < i; j++)
zclose(obj->maps[j].fd);
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tools lib bpf: improve warning
2017-08-20 19:48 [PATCH] tools lib bpf: improve warning Eric Leblond
@ 2017-08-20 21:45 ` Daniel Borkmann
2017-08-21 0:44 ` Alexei Starovoitov
2017-08-21 2:50 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Borkmann @ 2017-08-20 21:45 UTC (permalink / raw)
To: Eric Leblond; +Cc: netdev
On 08/20/2017 09:48 PM, Eric Leblond wrote:
> Signed-off-by: Eric Leblond <eric@regit.org>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools lib bpf: improve warning
2017-08-20 19:48 [PATCH] tools lib bpf: improve warning Eric Leblond
2017-08-20 21:45 ` Daniel Borkmann
@ 2017-08-21 0:44 ` Alexei Starovoitov
2017-08-21 2:50 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Alexei Starovoitov @ 2017-08-21 0:44 UTC (permalink / raw)
To: Eric Leblond; +Cc: netdev, Wangnan
On Sun, Aug 20, 2017 at 09:48:14PM +0200, Eric Leblond wrote:
> Signed-off-by: Eric Leblond <eric@regit.org>
> ---
> tools/lib/bpf/libbpf.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 1cc3ea0ffdc3..35f6dfcdc565 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -879,7 +879,8 @@ bpf_object__create_maps(struct bpf_object *obj)
> size_t j;
> int err = *pfd;
>
> - pr_warning("failed to create map: %s\n",
> + pr_warning("failed to create map (name: '%s'): %s\n",
> + obj->maps[i].name,
> strerror(errno));
makes sense.
Acked-by: Alexei Starovoitov <ast@kernel.org>
Please cc Wang for future libbpf patches.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tools lib bpf: improve warning
2017-08-20 19:48 [PATCH] tools lib bpf: improve warning Eric Leblond
2017-08-20 21:45 ` Daniel Borkmann
2017-08-21 0:44 ` Alexei Starovoitov
@ 2017-08-21 2:50 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-08-21 2:50 UTC (permalink / raw)
To: eric; +Cc: netdev
From: Eric Leblond <eric@regit.org>
Date: Sun, 20 Aug 2017 21:48:14 +0200
> Signed-off-by: Eric Leblond <eric@regit.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-21 2:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-20 19:48 [PATCH] tools lib bpf: improve warning Eric Leblond
2017-08-20 21:45 ` Daniel Borkmann
2017-08-21 0:44 ` Alexei Starovoitov
2017-08-21 2:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).