From: David Miller <davem@davemloft.net>
To: dsahern@gmail.com
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org,
hannes@stressinduktion.org
Subject: Re: [PATCH v2 net-next] net: ipv6: put host and anycast routes on device with address
Date: Mon, 21 Aug 2017 10:41:22 -0700 (PDT) [thread overview]
Message-ID: <20170821.104122.296287714831109265.davem@davemloft.net> (raw)
In-Reply-To: <1502997440-32334-1-git-send-email-dsahern@gmail.com>
From: David Ahern <dsahern@gmail.com>
Date: Thu, 17 Aug 2017 12:17:20 -0700
> One nagging difference between ipv4 and ipv6 is host routes for ipv6
> addresses are installed using the loopback device or VRF / L3 Master
> device. e.g.,
>
> 2001:db8:1::/120 dev veth0 proto kernel metric 256 pref medium
> local 2001:db8:1::1 dev lo table local proto kernel metric 0 pref medium
>
> Using the loopback device is convenient -- necessary for local tx, but
> has some nasty side effects, most notably setting the 'lo' device down
> causes all host routes for all local IPv6 address to be removed from the
> FIB and completely breaks IPv6 networking across all interfaces.
>
> This patch puts FIB entries for IPv6 routes against the device. This
> simplifies the routes in the FIB, for example by making dst->dev and
> rt6i_idev->dev the same (a future patch can look at removing the device
> reference taken for rt6i_idev for FIB entries).
>
> When copies are made on FIB lookups, the cloned route has dst->dev
> set to loopback (or the L3 master device). This is needed for the
> local Tx of packets to local addresses.
>
> With fib entries allocated against the real network device, the addrconf
> code that reinserts host routes on admin up of 'lo' is no longer needed.
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
I've applied this.
I'm unlikely to revert this just for java, given the kinds of things
they are doing.
prev parent reply other threads:[~2017-08-21 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 19:17 [PATCH v2 net-next] net: ipv6: put host and anycast routes on device with address David Ahern
2017-08-18 23:15 ` Hannes Frederic Sowa
2017-08-19 0:05 ` David Ahern
2017-08-19 0:14 ` David Ahern
2017-08-19 0:28 ` Hannes Frederic Sowa
2017-08-21 13:19 ` David Ahern
2017-08-20 4:53 ` David Miller
2017-08-21 17:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821.104122.296287714831109265.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).