From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH 4/6] dpaa_eth: add NETIF_F_RXHASH
Date: Mon, 21 Aug 2017 10:57:06 -0700 (PDT)
Message-ID: <20170821.105706.646457120423300952.davem@davemloft.net>
References: <1503046588-24349-1-git-send-email-madalin.bucur@nxp.com>
        <1503046588-24349-5-git-send-email-madalin.bucur@nxp.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
To: madalin.bucur@nxp.com
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1503046588-24349-5-git-send-email-madalin.bucur@nxp.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

From: Madalin Bucur <madalin.bucur@nxp.com>
Date: Fri, 18 Aug 2017 11:56:26 +0300

> +	if (net_dev->features & NETIF_F_RXHASH && priv->keygen_in_use &&
> +	    !fman_port_get_hash_result_offset(priv->mac_dev->port[RX],
> +					      &hash_offset))
> +		skb_set_hash(skb, be32_to_cpu(*(u32 *)(vaddr + hash_offset)),
> +			     // if L4 exists, it was used in the hash generation
> +			     be32_to_cpu(fd->status) & FM_FD_STAT_L4CV ?
> +				PKT_HASH_TYPE_L4 : PKT_HASH_TYPE_L3);

We do not use "//" c++ style comments in the kernel.

And putting a comment right in the middle of a set of arguments being
passed to a function makes the code harder to read, so please do not
do this.