From: "Yang, Yi" <yi.y.yang@intel.com>
To: Jiri Benc <jbenc@redhat.com>
Cc: netdev@vger.kernel.org, dev@openvswitch.org, blp@ovn.org,
e@erig.me, jan.scheurich@ericsson.com
Subject: Re: [PATCH net-next v5] openvswitch: enable NSH support
Date: Mon, 21 Aug 2017 16:41:02 +0800 [thread overview]
Message-ID: <20170821084101.GB74649@cran64.bj.intel.com> (raw)
In-Reply-To: <20170821102509.076d7cc9@griffin>
On Mon, Aug 21, 2017 at 10:25:09AM +0200, Jiri Benc wrote:
> On Mon, 21 Aug 2017 13:54:23 +0800, Yi Yang wrote:
> > v4->v5
> > - Fix many comments by Jiri Benc and Eric Garver
> > for v4.
>
> NACK for v5, we haven't finished discussing v4. You're sending new
> versions too quickly.
>
> My comment about sending a new version was meant only for the rest of
> the patch that I have not reviewed - i.e. that once the comments I've
> made so far are addressed, I'm fine with continuing reviewing in a new
> version.
>
> It did not mean that I'm okay with sending a new version without my
> comments to the first part being addressed. Which they are not, see my
> reply to your mail at v4.
>
> Sorry if that was not clear but I won't review v5 until we have
> conclusion for the v4 comments.
Ok, let me fix comments for v4 first.
>
> Jiri
next prev parent reply other threads:[~2017-08-21 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 5:54 [PATCH net-next v5] openvswitch: enable NSH support Yi Yang
[not found] ` <1503294863-12859-1-git-send-email-yi.y.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-08-21 8:25 ` Jiri Benc
2017-08-21 8:41 ` Yang, Yi [this message]
2017-08-22 22:26 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821084101.GB74649@cran64.bj.intel.com \
--to=yi.y.yang@intel.com \
--cc=blp@ovn.org \
--cc=dev@openvswitch.org \
--cc=e@erig.me \
--cc=jan.scheurich@ericsson.com \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).