From: Jiri Benc <jbenc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Yi Yang <yi.y.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, e@erig.me
Subject: Re: [PATCH net-next v5] openvswitch: enable NSH support
Date: Mon, 21 Aug 2017 10:25:09 +0200 [thread overview]
Message-ID: <20170821102509.076d7cc9@griffin> (raw)
In-Reply-To: <1503294863-12859-1-git-send-email-yi.y.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Mon, 21 Aug 2017 13:54:23 +0800, Yi Yang wrote:
> v4->v5
> - Fix many comments by Jiri Benc and Eric Garver
> for v4.
NACK for v5, we haven't finished discussing v4. You're sending new
versions too quickly.
My comment about sending a new version was meant only for the rest of
the patch that I have not reviewed - i.e. that once the comments I've
made so far are addressed, I'm fine with continuing reviewing in a new
version.
It did not mean that I'm okay with sending a new version without my
comments to the first part being addressed. Which they are not, see my
reply to your mail at v4.
Sorry if that was not clear but I won't review v5 until we have
conclusion for the v4 comments.
Jiri
next prev parent reply other threads:[~2017-08-21 8:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 5:54 [PATCH net-next v5] openvswitch: enable NSH support Yi Yang
[not found] ` <1503294863-12859-1-git-send-email-yi.y.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-08-21 8:25 ` Jiri Benc [this message]
2017-08-21 8:41 ` Yang, Yi
2017-08-22 22:26 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821102509.076d7cc9@griffin \
--to=jbenc-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org \
--cc=e@erig.me \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=yi.y.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).