From: Stephen Hemminger <stephen@networkplumber.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute PATCH v3 2/7] xfrm_state: Make sure alg_name is NULL-terminated
Date: Mon, 21 Aug 2017 17:28:20 -0700 [thread overview]
Message-ID: <20170821172541.6eb3e60c@xeon-e3> (raw)
In-Reply-To: <20170821132341.23118-3-phil@nwl.cc>
On Mon, 21 Aug 2017 15:23:36 +0200
Phil Sutter <phil@nwl.cc> wrote:
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
> ip/xfrm_state.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ip/xfrm_state.c b/ip/xfrm_state.c
> index e11c93bf1c3b5..7c0389038986e 100644
> --- a/ip/xfrm_state.c
> +++ b/ip/xfrm_state.c
> @@ -125,7 +125,8 @@ static int xfrm_algo_parse(struct xfrm_algo *alg, enum xfrm_attr_type_t type,
> fprintf(stderr, "warning: ALGO-NAME/ALGO-KEYMAT values will be sent to the kernel promiscuously! (verifying them isn't implemented yet)\n");
> #endif
>
> - strncpy(alg->alg_name, name, sizeof(alg->alg_name));
> + strncpy(alg->alg_name, name, sizeof(alg->alg_name) - 1);
> + alg->alg_name[sizeof(alg->alg_name) - 1] = '\0';
>
> if (slen > 2 && strncmp(key, "0x", 2) == 0) {
> /* split two chars "0x" from the top */
You are fixing enough of these null terminated string issues, that maybe
introducing strlcpy() would make sense. Either in utils (or -lbsd).
next prev parent reply other threads:[~2017-08-22 0:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 13:23 [iproute PATCH v3 0/7] Covscan: Fixes for string termination Phil Sutter
2017-08-21 13:23 ` [iproute PATCH v3 1/7] ipntable: Avoid memory allocation for filter.name Phil Sutter
2017-08-21 13:23 ` [iproute PATCH v3 2/7] xfrm_state: Make sure alg_name is NULL-terminated Phil Sutter
2017-08-22 0:28 ` Stephen Hemminger [this message]
2017-08-22 11:05 ` Phil Sutter
2017-08-21 13:23 ` [iproute PATCH v3 3/7] lib/fs: Fix format string in find_fs_mount() Phil Sutter
2017-08-21 13:23 ` [iproute PATCH v3 4/7] lib/inet_proto: Review inet_proto_{a2n,n2a}() Phil Sutter
2017-08-21 13:23 ` [iproute PATCH v3 5/7] lnstat_util: Simplify alloc_and_open() a bit Phil Sutter
2017-08-21 13:23 ` [iproute PATCH v3 6/7] tc/m_xt: Fix for potential string buffer overflows Phil Sutter
2017-08-21 13:23 ` [iproute PATCH v3 7/7] lib/ll_map: Choose size of new cache items at run-time Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821172541.6eb3e60c@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).