From: "Michael S. Tsirkin" <mst@redhat.com>
To: Koichiro Den <den@klaipeden.com>
Cc: jasowang@redhat.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] vhost: remove the possible fruitless search on iotlb prefetch
Date: Mon, 21 Aug 2017 22:45:58 +0300 [thread overview]
Message-ID: <20170821223039-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20170819064114.27219-1-den@klaipeden.com>
On Sat, Aug 19, 2017 at 03:41:14PM +0900, Koichiro Den wrote:
> Signed-off-by: Koichiro Den <den@klaipeden.com>
> ---
> drivers/vhost/vhost.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index e4613a3c362d..93e909afc1c3 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -1184,7 +1184,7 @@ static int iotlb_access_ok(struct vhost_virtqueue *vq,
> while (len > s) {
> node = vhost_umem_interval_tree_iter_first(&umem->umem_tree,
> addr,
> - addr + len - 1);
> + addr + len - s - 1);
> if (node == NULL || node->start > addr) {
> vhost_iotlb_miss(vq, addr, access);
> return false;
This works but it probably makes sense to just refactor the code to make end of
range a variable. I posted a patch like this, pls take a look.
> --
> 2.9.4
>
next prev parent reply other threads:[~2017-08-21 19:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-19 6:41 [PATCH 1/2] vhost: remove the possible fruitless search on iotlb prefetch Koichiro Den
2017-08-21 3:09 ` Jason Wang
2017-08-21 19:45 ` Michael S. Tsirkin [this message]
2017-08-22 14:09 ` Koichiro Den
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821223039-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=den@klaipeden.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).