From: David Miller <davem@davemloft.net>
To: andrew@aj.id.au
Cc: netdev@vger.kernel.org, benh@kernel.crashing.org, joel@jms.id.au,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-aspeed@lists.ozlabs.org, ryan_chen@aspeedtech.com
Subject: Re: [PATCH] net: ftgmac100: Fix oops in probe on failure to find associated PHY
Date: Tue, 22 Aug 2017 14:20:14 -0700 (PDT) [thread overview]
Message-ID: <20170822.142014.1004582480730502532.davem@davemloft.net> (raw)
In-Reply-To: <20170822063622.21550-1-andrew@aj.id.au>
From: Andrew Jeffery <andrew@aj.id.au>
Date: Tue, 22 Aug 2017 16:06:22 +0930
> netif_napi_del() should be paired with netif_napi_add(), however no
> such call takes place in ftgmac100_probe(). This triggers a NULL
> pointer dereference if e.g. no PHY is found by the MDIO probe:
...
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Applied, thanks.
prev parent reply other threads:[~2017-08-22 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 6:36 [PATCH] net: ftgmac100: Fix oops in probe on failure to find associated PHY Andrew Jeffery
2017-08-22 16:59 ` Benjamin Herrenschmidt
2017-08-22 21:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822.142014.1004582480730502532.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=joel@jms.id.au \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).